[fix][data] Apply chat-template kwargs during filtering - #2006
Draft
bvolpato wants to merge 1 commit into
Draft
Conversation
This was referenced Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
PromptDataset filters examples by calling tokenizer.apply_chat_template without generator.chat_template_kwargs. Generation later applies those kwargs. Options such as enable_thinking can change rendered prompt length, so filtering measures a different prompt from the one sent to inference. Over-length prompts may pass preprocessing and fail only at runtime; valid prompts can also be filtered using the wrong template mode.
Change
Why this belongs in SkyRL
SkyRL owns preprocessing and passes these tokenizer options during generation. Length filtering must use same configured kwargs to enforce trainer.max_prompt_length against prompt that will run. Fix applies to any tokenizer kwarg that changes rendering, not one model family.
Compatibility
Validation
CI note
Current full-tree Black failure is already present on main in tests/tinker/test_engine.py and is isolated in #2009.