Skip to content

CCM-15190: pre-commit -- ignore git submodules #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cgitim merged 1 commit into from
Jun 11, 2026
Merged

CCM-15190: pre-commit -- ignore git submodules #214

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/actions/check-english-usage/check-english-usage.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,13 +35,13 @@ function main() {
filter="git ls-files -z"
;;
"staged-changes")
filter="git diff --diff-filter=ACMRT --name-only --cached -z"
filter="git diff --diff-filter=ACMRT --name-only --cached --ignore-submodules=all -z"
;;
"working-tree-changes")
filter="git diff --diff-filter=ACMRT --name-only -z"
filter="git diff --diff-filter=ACMRT --name-only --ignore-submodules=all -z"
;;
"branch")
filter="git diff --diff-filter=ACMRT --name-only -z ${BRANCH_NAME:-origin/main}"
filter="git diff --diff-filter=ACMRT --name-only --ignore-submodules=all -z ${BRANCH_NAME:-origin/main}"
;;
*)
echo "Unrecognised check mode: $check" >&2 && exit 1
Expand Down
6 changes: 3 additions & 3 deletions .github/actions/check-file-format/check-file-format.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,13 +55,13 @@ function main() {
filter="git ls-files -z"
;;
"staged-changes")
filter="git diff --diff-filter=ACMRT --name-only --cached -z"
filter="git diff --diff-filter=ACMRT --name-only --cached --ignore-submodules=all -z"
;;
"working-tree-changes")
filter="git diff --diff-filter=ACMRT --name-only -z"
filter="git diff --diff-filter=ACMRT --name-only --ignore-submodules=all -z"
;;
"branch")
filter="git diff --diff-filter=ACMRT --name-only -z ${BRANCH_NAME:-origin/main}"
filter="git diff --diff-filter=ACMRT --name-only --ignore-submodules=all -z ${BRANCH_NAME:-origin/main}"
;;
*)
echo "Unrecognised check mode: $check" >&2 && exit 1
Expand Down
6 changes: 3 additions & 3 deletions .github/actions/check-markdown-format/check-markdown-format.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,13 +42,13 @@ function main() {
files="$(git ls-files "*.md")"
;;
"staged-changes")
files="$(git diff --diff-filter=ACMRT --name-only --cached "*.md")"
files="$(git diff --diff-filter=ACMRT --name-only --cached --ignore-submodules=all "*.md")"
;;
"working-tree-changes")
files="$(git diff --diff-filter=ACMRT --name-only "*.md")"
files="$(git diff --diff-filter=ACMRT --name-only --ignore-submodules=all "*.md")"
;;
"branch")
files="$( (git diff --diff-filter=ACMRT --name-only "${BRANCH_NAME:-origin/main}" "*.md"; git diff --name-only "*.md") | sort | uniq )"
files="$( (git diff --diff-filter=ACMRT --name-only --ignore-submodules=all "${BRANCH_NAME:-origin/main}" "*.md"; git diff --name-only --ignore-submodules=all "*.md") | sort | uniq )"
;;
esac

Expand Down
6 changes: 3 additions & 3 deletions .github/actions/check-todo-usage/check-todos.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,13 +65,13 @@ function get_files_to_check() {
local mode="$1"
case "$mode" in
staged-changes)
git diff --diff-filter=ACMRT --name-only --cached # ACMRT only show files added, copied, modified, renamed or that had their type changed (eg. file → symlink) in this commit. This leaves out deleted files.
git diff --diff-filter=ACMRT --name-only --cached --ignore-submodules=all # ACMRT only show files added, copied, modified, renamed or that had their type changed (eg. file → symlink) in this commit. This leaves out deleted files.
;;
working-tree-changes)
git ls-files --others --exclude-standard && git diff --diff-filter=ACMRT --name-only
git ls-files --others --exclude-standard && git diff --diff-filter=ACMRT --name-only --ignore-submodules=all
;;
branch)
git diff --diff-filter=ACMRT --name-only ${BRANCH_NAME:-origin/main}
git diff --diff-filter=ACMRT --name-only --ignore-submodules=all ${BRANCH_NAME:-origin/main}
;;
all)
git ls-files && git ls-files --others --exclude-standard
Expand Down
Loading