Skip to content

CCM-15190: pre-commit -- ignore git submodules#214

Merged
cgitim merged 1 commit into
mainfrom
feature/pre-commit-ignore-submodules
Jun 11, 2026
Merged

CCM-15190: pre-commit -- ignore git submodules#214
cgitim merged 1 commit into
mainfrom
feature/pre-commit-ignore-submodules

Conversation

@cgitim

@cgitim cgitim commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Description

For pre-commit scripts, when gathering files which have changes in git, ignore the paths to any submodules.

Context

In repositories that use git submodules, submodule pointer changes appear in diffs as directory paths. Pre-commit tools don't support this. E.g., editorconfig-checker (check-file-format hook) hangs and vale (check-english-usage hook) blows up with "stat: no such file or directory".

This change has no impact on repos without submodules.

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@cgitim cgitim requested a review from a team as a code owner June 11, 2026 15:17
@cgitim cgitim changed the title pre-commit: ignore git submodules CCM-15190: pre-commit -- ignore git submodules Jun 11, 2026
@cgitim cgitim merged commit 590b9cb into main Jun 11, 2026
49 of 51 checks passed
@cgitim cgitim deleted the feature/pre-commit-ignore-submodules branch June 11, 2026 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants