merge queue: checking main (a620bcb) and #12319 together - #12332
Closed
mergify[bot] wants to merge 2 commits into
Closed
merge queue: checking main (a620bcb) and #12319 together#12332mergify[bot] wants to merge 2 commits into
mergify[bot] wants to merge 2 commits into
Conversation
The engine renamed its documented-data-type flag from `x-has-data-type` to `x-mergify-has-data-type`, matching the namespacing already used for `x-mergify-enum`. An unprefixed `x-` key is a claim on a name nobody owns, which is how `x-enum-descriptions` ended up meaning a positional array of strings to openapi-generator and a map to us. Read the new spelling only. The engine publishes both today, so this is safe now — and reading only one is what makes dropping the other possible: while a consumer accepts either, nothing can tell which it actually depends on, so the removal can never be shown to be safe. This is the step that unblocks it. Only `isDataType` reads the flag — the anchor collector, both config tables and the build gate all go through it — so this is one predicate, not a sweep. The comments and the anchor-check message that named the old key are updated with it; a marker's name appearing in prose that no longer matches what the code looks for is how the next reader gets sent after the wrong thing. Part of MRGFY-8330 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Change-Id: I1575ebfdb9f97f7a6ecfa25815036b07836d026c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 This pull request has been checked successfully and will be merged soon. 🎉
Branch main (a620bcb) and #12319 are queued together for merge.
This pull request has been created by Mergify to check the mergeability of #12319.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.
Required conditions of queue rule
defaultfor merge:depends-on = Mergifyio/docs#12304[⛓️ fix(docs): sanitize the HTML the schema-driven tables inject #12304]github-review-approved[🛡 GitHub repository ruleset ruleRequire pull request for default branch]schedule=Mon-Fri 09:00-17:30[Europe/Paris]Enforce conventional commit]:title ~= ^(fix|feat|internal|docs|style|refactor|perf|test|build|ci|chore|revert|ui)(?:\(.+\))?!?:👀 Review Requirements]:#approved-reviews-by >= 2author = dependabot[bot]author = mergify-ci-bot-head ~= ^docs-agent/📕 PR description]:body ~= (?ms:.{48,})🔎 Reviews]:#changes-requested-reviews-by = 0#review-requested = 0#review-threads-unresolved = 0🤖 Continuous Integration]:check-success = buildcheck-success = lintcheck-success = testcheck-success = test-broken-linkslabel = ignore-broken-linkscheck-success=Cloudflare Pages-head-repo-full-name~=^Mergifyio/Required conditions to stay in the queue:
depends-on = Mergifyio/docs#12304[⛓️ fix(docs): sanitize the HTML the schema-driven tables inject #12304]github-review-approved[🛡 GitHub repository ruleset ruleRequire pull request for default branch]Enforce conventional commit]:title ~= ^(fix|feat|internal|docs|style|refactor|perf|test|build|ci|chore|revert|ui)(?:\(.+\))?!?:👀 Review Requirements]:#approved-reviews-by >= 2author = dependabot[bot]author = mergify-ci-bot-head ~= ^docs-agent/📕 PR description]:body ~= (?ms:.{48,})🔎 Reviews]:#changes-requested-reviews-by = 0#review-requested = 0#review-threads-unresolved = 0🤖 Continuous Integration]:check-success = buildcheck-success = lintcheck-success = testcheck-success = test-broken-linkslabel = ignore-broken-linkscheck-success=Cloudflare Pages-head-repo-full-name~=^Mergifyio/author != dependabot[bot]author != mergify-ci-bothead ~= ^docs-agent/