Skip to content

feat(docs): switch to the namespaced documented-data-type marker - #12319

Merged
mergify[bot] merged 1 commit into
mainfrom
devs/kozlek/devs/kozlek/batch-status-data-type/switch-namespaced-documented-data-type-marker--1575ebfd
Aug 6, 2026
Merged

feat(docs): switch to the namespaced documented-data-type marker#12319
mergify[bot] merged 1 commit into
mainfrom
devs/kozlek/devs/kozlek/batch-status-data-type/switch-namespaced-documented-data-type-marker--1575ebfd

Conversation

@kozlek

@kozlek kozlek commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

The engine renamed its documented-data-type flag from x-has-data-type
to x-mergify-has-data-type, matching the namespacing already used for
x-mergify-enum. An unprefixed x- key is a claim on a name nobody
owns, which is how x-enum-descriptions ended up meaning a positional
array of strings to openapi-generator and a map to us.

Read the new spelling only. The engine publishes both today, so this is
safe now — and reading only one is what makes dropping the other
possible: while a consumer accepts either, nothing can tell which it
actually depends on, so the removal can never be shown to be safe. This
is the step that unblocks it.

Only isDataType reads the flag — the anchor collector, both config
tables and the build gate all go through it — so this is one predicate,
not a sweep. The comments and the anchor-check message that named the
old key are updated with it; a marker's name appearing in prose that no
longer matches what the code looks for is how the next reader gets sent
after the wrong thing.

Part of MRGFY-8330

Co-Authored-By: Claude Opus 5 (1M context) noreply@anthropic.com

Depends-On: #12304

@mergify
mergify Bot had a problem deploying to Mergify Merge Protections August 5, 2026 13:52 Failure
@kozlek

kozlek commented Aug 5, 2026

Copy link
Copy Markdown
Contributor Author

This pull request is part of a Mergify stack:

# Pull Request Link
1 refactor(docs): read documented enum values through one shared reader #12293
2 fix(docs): sanitize the HTML the schema-driven tables inject #12304
3 feat(docs): switch to the namespaced documented-data-type marker #12319 👈
4 feat(docs): document the batch status data type #12263

@mergify

mergify Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Merge Protections

🟢 All 7 merge protections satisfied — ready to merge.

Show 7 satisfied protections

🟢 ⛓️ Depends-On Requirements

Requirement based on the presence of Depends-On in the body of the pull request

🟢 🤖 Continuous Integration

  • all of:
    • check-success = build
    • check-success = lint
    • check-success = test
    • any of:
      • check-success = test-broken-links
      • label = ignore-broken-links
    • any of:
      • check-success=Cloudflare Pages
      • -head-repo-full-name~=^Mergifyio/

🟢 👀 Review Requirements

  • any of:
    • #approved-reviews-by >= 2
    • author = dependabot[bot]
    • all of:
      • author = mergify-ci-bot
      • -head ~= ^docs-agent/

🟢 Enforce conventional commit

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|internal|docs|style|refactor|perf|test|build|ci|chore|revert|ui)(?:\(.+\))?!?:

🟢 🔎 Reviews

  • #changes-requested-reviews-by = 0
  • #review-requested = 0
  • #review-threads-unresolved = 0

🟢 📕 PR description

  • body ~= (?ms:.{48,})

🟢 🚦 Auto-queue

When all merge protections are satisfied, this pull request will be queued automatically.

@mergify
mergify Bot requested a review from a team August 5, 2026 13:54
@kozlek
kozlek marked this pull request as ready for review August 5, 2026 13:58
@kozlek
kozlek force-pushed the devs/kozlek/devs/kozlek/batch-status-data-type/switch-namespaced-documented-data-type-marker--1575ebfd branch from 48a347c to a05bc6a Compare August 5, 2026 14:01
@kozlek
kozlek force-pushed the devs/kozlek/devs/kozlek/batch-status-data-type/sanitize-html-schema-driven-tables-inject--ce1642f8 branch from 08912d8 to 452a467 Compare August 5, 2026 14:01
@kozlek

kozlek commented Aug 5, 2026

Copy link
Copy Markdown
Contributor Author

Revision history

# Type Changes Reason Date
1 initial 48a347c 2026-08-05 14:00 UTC
2 rebase 48a347c → a05bc6a (rebase only) 2026-08-05 14:00 UTC
3 rebase 377f628 → ec818fc (rebase only) 2026-08-06 07:53 UTC

@mergify
mergify Bot had a problem deploying to Mergify Merge Protections August 5, 2026 14:02 Failure
@mergify
mergify Bot force-pushed the devs/kozlek/devs/kozlek/batch-status-data-type/sanitize-html-schema-driven-tables-inject--ce1642f8 branch from 452a467 to 8a5dfdd Compare August 6, 2026 07:10
@mergify
mergify Bot force-pushed the devs/kozlek/devs/kozlek/batch-status-data-type/switch-namespaced-documented-data-type-marker--1575ebfd branch from a05bc6a to 377f628 Compare August 6, 2026 07:15
@mergify
mergify Bot had a problem deploying to Mergify Merge Protections August 6, 2026 07:15 Failure
The engine renamed its documented-data-type flag from `x-has-data-type`
to `x-mergify-has-data-type`, matching the namespacing already used for
`x-mergify-enum`. An unprefixed `x-` key is a claim on a name nobody
owns, which is how `x-enum-descriptions` ended up meaning a positional
array of strings to openapi-generator and a map to us.

Read the new spelling only. The engine publishes both today, so this is
safe now — and reading only one is what makes dropping the other
possible: while a consumer accepts either, nothing can tell which it
actually depends on, so the removal can never be shown to be safe. This
is the step that unblocks it.

Only `isDataType` reads the flag — the anchor collector, both config
tables and the build gate all go through it — so this is one predicate,
not a sweep. The comments and the anchor-check message that named the
old key are updated with it; a marker's name appearing in prose that no
longer matches what the code looks for is how the next reader gets sent
after the wrong thing.

Part of MRGFY-8330

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Change-Id: I1575ebfdb9f97f7a6ecfa25815036b07836d026c
@kozlek
kozlek force-pushed the devs/kozlek/devs/kozlek/batch-status-data-type/switch-namespaced-documented-data-type-marker--1575ebfd branch from 377f628 to ec818fc Compare August 6, 2026 07:53
@kozlek
kozlek force-pushed the devs/kozlek/devs/kozlek/batch-status-data-type/sanitize-html-schema-driven-tables-inject--ce1642f8 branch from 8a5dfdd to 49f486e Compare August 6, 2026 07:53
@mergify
mergify Bot had a problem deploying to Mergify Merge Protections August 6, 2026 07:53 Failure
@mergify
mergify Bot force-pushed the devs/kozlek/devs/kozlek/batch-status-data-type/sanitize-html-schema-driven-tables-inject--ce1642f8 branch from 49f486e to 3e83b56 Compare August 6, 2026 08:12
@mergify
mergify Bot force-pushed the devs/kozlek/devs/kozlek/batch-status-data-type/switch-namespaced-documented-data-type-marker--1575ebfd branch from ec818fc to bf25bff Compare August 6, 2026 08:20
@mergify
mergify Bot had a problem deploying to Mergify Merge Protections August 6, 2026 08:20 Failure
Base automatically changed from devs/kozlek/devs/kozlek/batch-status-data-type/sanitize-html-schema-driven-tables-inject--ce1642f8 to main August 6, 2026 08:37
@mergify
mergify Bot force-pushed the devs/kozlek/devs/kozlek/batch-status-data-type/switch-namespaced-documented-data-type-marker--1575ebfd branch from bf25bff to 08dfd84 Compare August 6, 2026 08:37
@mergify
mergify Bot deployed to Mergify Merge Protections August 6, 2026 08:37 Active
@mergify
mergify Bot requested a review from a team August 6, 2026 08:43
@mergify

mergify Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Merge Queue Status

This pull request spent 2 minutes 39 seconds in the queue, including 2 minutes 8 seconds running CI.

Required conditions to merge

@mergify mergify Bot added the queued label Aug 6, 2026
@mergify
mergify Bot merged commit e6f5114 into main Aug 6, 2026
10 checks passed
@mergify
mergify Bot deleted the devs/kozlek/devs/kozlek/batch-status-data-type/switch-namespaced-documented-data-type-marker--1575ebfd branch August 6, 2026 09:48
@mergify mergify Bot removed the queued label Aug 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants