Skip to content

fix(network): enforce RFC-compliant SASL authentication - #2163

Merged
mbuckton merged 1 commit into
developmentfrom
MAPS-0-rfc-compliant-sasl
Aug 7, 2026
Merged

fix(network): enforce RFC-compliant SASL authentication#2163
mbuckton merged 1 commit into
developmentfrom
MAPS-0-rfc-compliant-sasl

Conversation

@mbuckton

@mbuckton mbuckton commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Summary

  • allowlist SCRAM-SHA-256 and PLAIN at the server boundary
  • require SSL, DTLS, or WSS before accepting PLAIN
  • require exact MQTT enhanced-auth method names and client-first authentication data
  • enforce authorization identity equality, exchange limits, and post-close rejection
  • dispose SASL state from MQTT 5, MQTT-SN 2, and AMQP protocol lifecycles
  • migrate server test clients and endpoint configuration from CRAM-MD5/SCRAM-SHA-512 to SCRAM-SHA-256

Tests

  • server mechanism allowlist and protected-transport policy
  • callback ordering and authorization identity rejection
  • existing MQTT 5 and MQTT-SN integration clients updated for client-first SCRAM-SHA-256
  • focused Java 21 compilation of the SASL boundary
  • end-to-end SCRAM-SHA-256 and protected PLAIN exchanges through the server wrapper

Depends on Maps-Messaging/authentication_library#465.

Full Maven resolution was unavailable in the managed environment because the project depends on Maps/private build artifacts.

SECURITY: restrict endpoints to SCRAM-SHA-256 and protected PLAIN
@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 1bfe8f55-1c3e-4008-93d5-a2db225517b0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mbuckton
mbuckton marked this pull request as ready for review August 7, 2026 06:57
@mbuckton
mbuckton merged commit 60fc29a into development Aug 7, 2026
2 of 3 checks passed
@mbuckton
mbuckton deleted the MAPS-0-rfc-compliant-sasl branch August 7, 2026 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant