Skip to content

Analyze more complex factory functions #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fantazio merged 3 commits into from
Aug 22, 2026
Merged

Analyze more complex factory functions #99

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
603ded9
[examples][docs][methods] improve factory_dun_indir
fantazio Aug 21, 2026
25b6055
[src][deadObj] fix factory_fun_indir
fantazio Aug 21, 2026
7860ebb
[docs][methods] move factory_fun_indir to code_constructs
fantazio Aug 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions check/classic/classic.exp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,6 @@

./examples/docs/methods/code_constructs/immediate_object/immediate_object_bin.ml:2: unused_obj

./examples/docs/methods/limitations/factory_fun_indir/factory_fun_indir.ml:2: factory_with_intermediate_binding
./examples/docs/methods/limitations/factory_fun_indir/factory_fun_indir.ml:8: random_factory

./examples/docs/optional_arguments/code_constructs/hof/hof_bin.ml:9: add_index

./examples/docs/optional_arguments/code_constructs/internal_app/internal_app_lib.mli:2: max
Expand Down Expand Up @@ -192,16 +189,16 @@ Nothing else to report in this section
./examples/docs/methods/code_constructs/factory_fun/factory_fun_bin.ml:2: unused_factory#unused_method
./examples/docs/methods/code_constructs/factory_fun/factory_fun_lib.mli:2: get_stack#reset

./examples/docs/methods/code_constructs/factory_fun_indir/factory_fun_indir.ml:2: factory_with_intermediate_binding#unused
./examples/docs/methods/code_constructs/factory_fun_indir/factory_fun_indir.ml:13: random_factory#unused

./examples/docs/methods/code_constructs/immediate_object/immediate_object_bin.ml:2: unused_obj#unused_method
./examples/docs/methods/code_constructs/immediate_object/immediate_object_lib.mli:2: int_stack#reset

./examples/docs/methods/code_constructs/inheritance/inheritance_lib.mli:2: parent#unused

./examples/docs/methods/code_constructs/polymorphic_class/polymorphic_class_lib.mli:2: stack#reset

./examples/docs/methods/limitations/factory_fun_indir/factory_fun_indir.ml:2: factory_with_intermediate_binding#m
./examples/docs/methods/limitations/factory_fun_indir/factory_fun_indir.ml:8: random_factory#m

./examples/using_dune/preprocessed_lib/preprocessed.mli:6: immediate#unused
./examples/using_dune/preprocessed_lib/preprocessed_no_intf.ml:12: immediate#unused

Expand Down Expand Up @@ -673,8 +670,7 @@ Nothing else to report in this section
./examples/docs/exported_values/code_constructs/module/module_lib.ml:6: unit pattern unused
./examples/docs/exported_values/code_constructs/module/module_lib.ml:7: unit pattern unused_unexported

./examples/docs/methods/limitations/factory_fun_indir/factory_fun_indir.ml:3: let x = ... in x (=> useless binding)
./examples/docs/methods/limitations/factory_fun_indir/factory_fun_indir.ml:12: let x = ... in x (=> useless binding)
./examples/docs/methods/code_constructs/factory_fun_indir/factory_fun_indir.ml:20: let x = ... in x (=> useless binding)

./examples/docs/optional_arguments/code_constructs/hof/hof_bin.ml:2: val f: ... -> (... -> ?_:_ -> ...) -> ...

Expand Down
19 changes: 8 additions & 11 deletions check/classic/classic.ref
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,6 @@

./examples/docs/methods/code_constructs/immediate_object/immediate_object_bin.ml:2: unused_obj

./examples/docs/methods/limitations/factory_fun_indir/factory_fun_indir.ml:2: factory_with_intermediate_binding
./examples/docs/methods/limitations/factory_fun_indir/factory_fun_indir.ml:8: random_factory

./examples/docs/optional_arguments/code_constructs/hof/hof_bin.ml:9: add_index

./examples/docs/optional_arguments/code_constructs/internal_app/internal_app_lib.mli:2: max
Expand Down Expand Up @@ -192,15 +189,16 @@ Nothing else to report in this section
./examples/docs/methods/code_constructs/factory_fun/factory_fun_bin.ml:2: unused_factory#unused_method
./examples/docs/methods/code_constructs/factory_fun/factory_fun_lib.mli:2: get_stack#reset

./examples/docs/methods/code_constructs/factory_fun_indir/factory_fun_indir.ml:2: factory_with_intermediate_binding#unused
./examples/docs/methods/code_constructs/factory_fun_indir/factory_fun_indir.ml:13: random_factory#unused

./examples/docs/methods/code_constructs/immediate_object/immediate_object_bin.ml:2: unused_obj#unused_method
./examples/docs/methods/code_constructs/immediate_object/immediate_object_lib.mli:2: int_stack#reset

./examples/docs/methods/code_constructs/inheritance/inheritance_lib.mli:2: parent#unused

./examples/docs/methods/code_constructs/polymorphic_class/polymorphic_class_lib.mli:2: stack#reset

./examples/docs/methods/limitations/factory_fun_indir/factory_fun_indir.ml:2: factory_with_intermediate_binding#m: Not detected
./examples/docs/methods/limitations/factory_fun_indir/factory_fun_indir.ml:8: random_factory#m: Not detected
./examples/using_dune/preprocessed_lib/preprocessed.mli:6: immediate#unused
./examples/using_dune/preprocessed_lib/preprocessed_no_intf.ml:12: immediate#unused

Expand Down Expand Up @@ -672,8 +670,7 @@ Nothing else to report in this section
./examples/docs/exported_values/code_constructs/module/module_lib.ml:6: unit pattern unused
./examples/docs/exported_values/code_constructs/module/module_lib.ml:7: unit pattern unused_unexported

./examples/docs/methods/limitations/factory_fun_indir/factory_fun_indir.ml:3: let x = ... in x (=> useless binding)
./examples/docs/methods/limitations/factory_fun_indir/factory_fun_indir.ml:12: let x = ... in x (=> useless binding)
./examples/docs/methods/code_constructs/factory_fun_indir/factory_fun_indir.ml:20: let x = ... in x (=> useless binding)

./examples/docs/optional_arguments/code_constructs/hof/hof_bin.ml:2: val f: ... -> (... -> ?_:_ -> ...) -> ...

Expand Down Expand Up @@ -724,7 +721,7 @@ Nothing else to report in this section
--------------------------------------------------------------------------------


Total: 596
Success: 594
Failed: 2
Ratio: 99.6644295302%
Total: 593
Success: 593
Failed: 0
Ratio: 100.%
12 changes: 4 additions & 8 deletions check/internal/internal.exp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,6 @@

./examples/docs/methods/code_constructs/immediate_object/immediate_object_bin.ml:2: unused_obj

./examples/docs/methods/limitations/factory_fun_indir/factory_fun_indir.ml:2: factory_with_intermediate_binding
./examples/docs/methods/limitations/factory_fun_indir/factory_fun_indir.ml:8: random_factory

./examples/docs/optional_arguments/code_constructs/hof/hof_bin.ml:9: add_index

./examples/using_dune/preprocessed_lib/preprocessed.mli:1: unused
Expand Down Expand Up @@ -144,16 +141,16 @@ Nothing else to report in this section
./examples/docs/methods/code_constructs/factory_fun/factory_fun_bin.ml:2: unused_factory#unused_method
./examples/docs/methods/code_constructs/factory_fun/factory_fun_lib.mli:2: get_stack#reset

./examples/docs/methods/code_constructs/factory_fun_indir/factory_fun_indir.ml:2: factory_with_intermediate_binding#unused
./examples/docs/methods/code_constructs/factory_fun_indir/factory_fun_indir.ml:13: random_factory#unused

./examples/docs/methods/code_constructs/immediate_object/immediate_object_bin.ml:2: unused_obj#unused_method
./examples/docs/methods/code_constructs/immediate_object/immediate_object_lib.mli:2: int_stack#reset

./examples/docs/methods/code_constructs/inheritance/inheritance_lib.mli:2: parent#unused

./examples/docs/methods/code_constructs/polymorphic_class/polymorphic_class_lib.mli:2: stack#reset

./examples/docs/methods/limitations/factory_fun_indir/factory_fun_indir.ml:2: factory_with_intermediate_binding#m
./examples/docs/methods/limitations/factory_fun_indir/factory_fun_indir.ml:8: random_factory#m

./examples/using_dune/preprocessed_lib/preprocessed.mli:6: immediate#unused
./examples/using_dune/preprocessed_lib/preprocessed_no_intf.ml:12: immediate#unused

Expand Down Expand Up @@ -625,8 +622,7 @@ Nothing else to report in this section
./examples/docs/exported_values/code_constructs/module/module_lib.ml:6: unit pattern unused
./examples/docs/exported_values/code_constructs/module/module_lib.ml:7: unit pattern unused_unexported

./examples/docs/methods/limitations/factory_fun_indir/factory_fun_indir.ml:3: let x = ... in x (=> useless binding)
./examples/docs/methods/limitations/factory_fun_indir/factory_fun_indir.ml:12: let x = ... in x (=> useless binding)
./examples/docs/methods/code_constructs/factory_fun_indir/factory_fun_indir.ml:20: let x = ... in x (=> useless binding)

./examples/docs/optional_arguments/code_constructs/hof/hof_bin.ml:2: val f: ... -> (... -> ?_:_ -> ...) -> ...

Expand Down
19 changes: 8 additions & 11 deletions check/internal/internal.ref
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,6 @@

./examples/docs/methods/code_constructs/immediate_object/immediate_object_bin.ml:2: unused_obj

./examples/docs/methods/limitations/factory_fun_indir/factory_fun_indir.ml:2: factory_with_intermediate_binding
./examples/docs/methods/limitations/factory_fun_indir/factory_fun_indir.ml:8: random_factory

./examples/docs/optional_arguments/code_constructs/hof/hof_bin.ml:9: add_index

./examples/using_dune/preprocessed_lib/preprocessed.mli:1: unused
Expand Down Expand Up @@ -144,15 +141,16 @@ Nothing else to report in this section
./examples/docs/methods/code_constructs/factory_fun/factory_fun_bin.ml:2: unused_factory#unused_method
./examples/docs/methods/code_constructs/factory_fun/factory_fun_lib.mli:2: get_stack#reset

./examples/docs/methods/code_constructs/factory_fun_indir/factory_fun_indir.ml:2: factory_with_intermediate_binding#unused
./examples/docs/methods/code_constructs/factory_fun_indir/factory_fun_indir.ml:13: random_factory#unused

./examples/docs/methods/code_constructs/immediate_object/immediate_object_bin.ml:2: unused_obj#unused_method
./examples/docs/methods/code_constructs/immediate_object/immediate_object_lib.mli:2: int_stack#reset

./examples/docs/methods/code_constructs/inheritance/inheritance_lib.mli:2: parent#unused

./examples/docs/methods/code_constructs/polymorphic_class/polymorphic_class_lib.mli:2: stack#reset

./examples/docs/methods/limitations/factory_fun_indir/factory_fun_indir.ml:2: factory_with_intermediate_binding#m: Not detected
./examples/docs/methods/limitations/factory_fun_indir/factory_fun_indir.ml:8: random_factory#m: Not detected
./examples/using_dune/preprocessed_lib/preprocessed.mli:6: immediate#unused
./examples/using_dune/preprocessed_lib/preprocessed_no_intf.ml:12: immediate#unused

Expand Down Expand Up @@ -624,8 +622,7 @@ Nothing else to report in this section
./examples/docs/exported_values/code_constructs/module/module_lib.ml:6: unit pattern unused
./examples/docs/exported_values/code_constructs/module/module_lib.ml:7: unit pattern unused_unexported

./examples/docs/methods/limitations/factory_fun_indir/factory_fun_indir.ml:3: let x = ... in x (=> useless binding)
./examples/docs/methods/limitations/factory_fun_indir/factory_fun_indir.ml:12: let x = ... in x (=> useless binding)
./examples/docs/methods/code_constructs/factory_fun_indir/factory_fun_indir.ml:20: let x = ... in x (=> useless binding)

./examples/docs/optional_arguments/code_constructs/hof/hof_bin.ml:2: val f: ... -> (... -> ?_:_ -> ...) -> ...

Expand Down Expand Up @@ -676,7 +673,7 @@ Nothing else to report in this section
--------------------------------------------------------------------------------


Total: 552
Success: 550
Failed: 2
Ratio: 99.6376811594%
Total: 549
Success: 549
Failed: 0
Ratio: 100.%
19 changes: 11 additions & 8 deletions check/threshold-1/threshold-1.exp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,6 @@

./examples/docs/methods/code_constructs/immediate_object/immediate_object_bin.ml:2: unused_obj

./examples/docs/methods/limitations/factory_fun_indir/factory_fun_indir.ml:2: factory_with_intermediate_binding
./examples/docs/methods/limitations/factory_fun_indir/factory_fun_indir.ml:8: random_factory

./examples/docs/optional_arguments/code_constructs/hof/hof_bin.ml:9: add_index

./examples/using_dune/preprocessed_lib/preprocessed.mli:1: unused
Expand Down Expand Up @@ -197,6 +194,9 @@

./examples/docs/methods/code_constructs/factory_fun/factory_fun_bin.ml:4: push_n_times

./examples/docs/methods/code_constructs/factory_fun_indir/factory_fun_indir.ml:2: factory_with_intermediate_binding
./examples/docs/methods/code_constructs/factory_fun_indir/factory_fun_indir.ml:13: random_factory

./examples/docs/methods/code_constructs/immediate_object/immediate_object_bin.ml:4: push_n_times

./examples/docs/methods/code_constructs/object_type/object_type_bin.ml:4: push_n_times
Expand Down Expand Up @@ -435,16 +435,16 @@ Nothing else to report in this section
./examples/docs/methods/code_constructs/factory_fun/factory_fun_bin.ml:2: unused_factory#unused_method
./examples/docs/methods/code_constructs/factory_fun/factory_fun_lib.mli:2: get_stack#reset

./examples/docs/methods/code_constructs/factory_fun_indir/factory_fun_indir.ml:2: factory_with_intermediate_binding#unused
./examples/docs/methods/code_constructs/factory_fun_indir/factory_fun_indir.ml:13: random_factory#unused

./examples/docs/methods/code_constructs/immediate_object/immediate_object_bin.ml:2: unused_obj#unused_method
./examples/docs/methods/code_constructs/immediate_object/immediate_object_lib.mli:2: int_stack#reset

./examples/docs/methods/code_constructs/inheritance/inheritance_lib.mli:2: parent#unused

./examples/docs/methods/code_constructs/polymorphic_class/polymorphic_class_lib.mli:2: stack#reset

./examples/docs/methods/limitations/factory_fun_indir/factory_fun_indir.ml:2: factory_with_intermediate_binding#m
./examples/docs/methods/limitations/factory_fun_indir/factory_fun_indir.ml:8: random_factory#m

./examples/using_dune/preprocessed_lib/preprocessed.mli:6: immediate#unused
./examples/using_dune/preprocessed_lib/preprocessed_no_intf.ml:12: immediate#unused

Expand Down Expand Up @@ -522,6 +522,10 @@ Nothing else to report in this section
./examples/docs/methods/code_constructs/factory_fun/factory_fun_lib.mli:2: get_stack#pop
./examples/docs/methods/code_constructs/factory_fun/factory_fun_lib.mli:2: get_stack#push

./examples/docs/methods/code_constructs/factory_fun_indir/factory_fun_indir.ml:2: factory_with_intermediate_binding#used
./examples/docs/methods/code_constructs/factory_fun_indir/factory_fun_indir.ml:2: factory_with_intermediate_binding#used_locally
./examples/docs/methods/code_constructs/factory_fun_indir/factory_fun_indir.ml:13: random_factory#used

./examples/docs/methods/code_constructs/immediate_object/immediate_object_lib.mli:2: int_stack#peek
./examples/docs/methods/code_constructs/immediate_object/immediate_object_lib.mli:2: int_stack#pop
./examples/docs/methods/code_constructs/immediate_object/immediate_object_lib.mli:2: int_stack#push
Expand Down Expand Up @@ -1090,8 +1094,7 @@ Nothing else to report in this section
./examples/docs/exported_values/code_constructs/module/module_lib.ml:6: unit pattern unused
./examples/docs/exported_values/code_constructs/module/module_lib.ml:7: unit pattern unused_unexported

./examples/docs/methods/limitations/factory_fun_indir/factory_fun_indir.ml:3: let x = ... in x (=> useless binding)
./examples/docs/methods/limitations/factory_fun_indir/factory_fun_indir.ml:12: let x = ... in x (=> useless binding)
./examples/docs/methods/code_constructs/factory_fun_indir/factory_fun_indir.ml:20: let x = ... in x (=> useless binding)

./examples/docs/optional_arguments/code_constructs/hof/hof_bin.ml:2: val f: ... -> (... -> ?_:_ -> ...) -> ...

Expand Down
26 changes: 15 additions & 11 deletions check/threshold-1/threshold-1.ref
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,6 @@

./examples/docs/methods/code_constructs/immediate_object/immediate_object_bin.ml:2: unused_obj

./examples/docs/methods/limitations/factory_fun_indir/factory_fun_indir.ml:2: factory_with_intermediate_binding
./examples/docs/methods/limitations/factory_fun_indir/factory_fun_indir.ml:8: random_factory

./examples/docs/optional_arguments/code_constructs/hof/hof_bin.ml:9: add_index

./examples/using_dune/preprocessed_lib/preprocessed.mli:1: unused
Expand Down Expand Up @@ -197,6 +194,9 @@

./examples/docs/methods/code_constructs/factory_fun/factory_fun_bin.ml:4: push_n_times

./examples/docs/methods/code_constructs/factory_fun_indir/factory_fun_indir.ml:2: factory_with_intermediate_binding
./examples/docs/methods/code_constructs/factory_fun_indir/factory_fun_indir.ml:13: random_factory

./examples/docs/methods/code_constructs/immediate_object/immediate_object_bin.ml:4: push_n_times

./examples/docs/methods/code_constructs/object_type/object_type_bin.ml:4: push_n_times
Expand Down Expand Up @@ -435,15 +435,16 @@ Nothing else to report in this section
./examples/docs/methods/code_constructs/factory_fun/factory_fun_bin.ml:2: unused_factory#unused_method
./examples/docs/methods/code_constructs/factory_fun/factory_fun_lib.mli:2: get_stack#reset

./examples/docs/methods/code_constructs/factory_fun_indir/factory_fun_indir.ml:2: factory_with_intermediate_binding#unused
./examples/docs/methods/code_constructs/factory_fun_indir/factory_fun_indir.ml:13: random_factory#unused

./examples/docs/methods/code_constructs/immediate_object/immediate_object_bin.ml:2: unused_obj#unused_method
./examples/docs/methods/code_constructs/immediate_object/immediate_object_lib.mli:2: int_stack#reset

./examples/docs/methods/code_constructs/inheritance/inheritance_lib.mli:2: parent#unused

./examples/docs/methods/code_constructs/polymorphic_class/polymorphic_class_lib.mli:2: stack#reset

./examples/docs/methods/limitations/factory_fun_indir/factory_fun_indir.ml:2: factory_with_intermediate_binding#m: Not detected
./examples/docs/methods/limitations/factory_fun_indir/factory_fun_indir.ml:8: random_factory#m: Not detected
./examples/using_dune/preprocessed_lib/preprocessed.mli:6: immediate#unused
./examples/using_dune/preprocessed_lib/preprocessed_no_intf.ml:12: immediate#unused

Expand Down Expand Up @@ -521,6 +522,10 @@ Nothing else to report in this section
./examples/docs/methods/code_constructs/factory_fun/factory_fun_lib.mli:2: get_stack#pop
./examples/docs/methods/code_constructs/factory_fun/factory_fun_lib.mli:2: get_stack#push

./examples/docs/methods/code_constructs/factory_fun_indir/factory_fun_indir.ml:2: factory_with_intermediate_binding#used
./examples/docs/methods/code_constructs/factory_fun_indir/factory_fun_indir.ml:2: factory_with_intermediate_binding#used_locally
./examples/docs/methods/code_constructs/factory_fun_indir/factory_fun_indir.ml:13: random_factory#used

./examples/docs/methods/code_constructs/immediate_object/immediate_object_lib.mli:2: int_stack#peek
./examples/docs/methods/code_constructs/immediate_object/immediate_object_lib.mli:2: int_stack#pop
./examples/docs/methods/code_constructs/immediate_object/immediate_object_lib.mli:2: int_stack#push
Expand Down Expand Up @@ -1089,8 +1094,7 @@ Nothing else to report in this section
./examples/docs/exported_values/code_constructs/module/module_lib.ml:6: unit pattern unused
./examples/docs/exported_values/code_constructs/module/module_lib.ml:7: unit pattern unused_unexported

./examples/docs/methods/limitations/factory_fun_indir/factory_fun_indir.ml:3: let x = ... in x (=> useless binding)
./examples/docs/methods/limitations/factory_fun_indir/factory_fun_indir.ml:12: let x = ... in x (=> useless binding)
./examples/docs/methods/code_constructs/factory_fun_indir/factory_fun_indir.ml:20: let x = ... in x (=> useless binding)

./examples/docs/optional_arguments/code_constructs/hof/hof_bin.ml:2: val f: ... -> (... -> ?_:_ -> ...) -> ...

Expand Down Expand Up @@ -1141,7 +1145,7 @@ Nothing else to report in this section
--------------------------------------------------------------------------------


Total: 937
Success: 935
Failed: 2
Ratio: 99.7865528282%
Total: 939
Success: 939
Failed: 0
Ratio: 100.%
Loading
Loading