Analyze more complex factory functions - #99
Merged
Conversation
The limitation was only testing for a single unused method. Now it tests methods unused, used locally, and methods used outside the factory.
In `add_var`, new expr constructs are now traversed to link the locally defined return value to the new value, and explore the branches on ifs, matches and tries. In `repr_exp`, `Texp_let` is not traversed. As a result, the FP/FN of the limitation are fixes.
It is referenced by the factory function documentation, and not a limitation anymore. The tests have been moved accordingly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #67
Factory function's methods were only analyzed when the function returned a immediate object in a single branch.
Now, functions with branches and intermediate bindings to the returned object are tolerated.
The tests for the
factory_fun_indirlimitation have been enhanced, are now passing and have been moved tocode_constructs. The documentation is updated to reflect the fix and reference the examples in the Factory Function's documentation.