feat(agent-harness): expose named authorized resource reads - #5718
Open
iscekic wants to merge 1 commit into
Open
feat(agent-harness): expose named authorized resource reads#5718iscekic wants to merge 1 commit into
iscekic wants to merge 1 commit into
Conversation
This was referenced Aug 29, 2026
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (2 files)
Reviewed by grok-4.6 · Input: 348.6K · Output: 20.9K · Cached: 1.5M Review guidance: REVIEW.md from base branch |
This was referenced Aug 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No new behavior — the product does not yet use these additions.
Summary
executeHarnessReadimplementskilo.organizations,kilo.members,kilo.usage, andkilo.repositorieswith strictInvocationSchemavalidation and dispatch-bound authorization.The adapter takes scope only from authority and reuses authorized procedures, so existing permissions and consumer contracts remain unchanged.
Results must fit 64 kibibytes (KiB); lists contain at most 50 items without a cursor, and provider failures remain errors instead of partial success.
Files
apps/web/src/lib/agent-harness/kilo-reads.ts— source, added; 179 lines. Validates and lowercases conversation and operation identifiers, rejects extra invocation fields and unknown reads, and accepts only empty tool arguments. Capability checks bind the audience, conversation, operation, definition version, input digest, dispatch identifier, and backend target. Organization results deduplicate direct and inherited memberships within the authorized scope before limiting and expose only identifiers and names. Member reads require an organization and return public identifiers, emails, and roles; pending invitations use email identifiers. Usage uses day granularity and cost-based totals for the previous 30 days, adds explicit dates, and selects personal-only or organization-wide reads. Repository reads combine bounded GitHub, GitLab, then organization-only Bitbucket results without forced refresh, returning provider-prefixed identifiers and full names. If no integration is available, the read produces a precondition error; an available provider can return an empty list. Temporary failures, setup failures, permission failures, bad requests, and size limits keep distinct errors, including after earlier providers fill the page. If GitHub or GitLab reports no explicit failure state, a missing status or provider error message produces a sanitized service error. Output schemas validate results and exclude extra fields before the adapter enforces the serialized byte limit.Tests: 1 file added,
apps/web/src/lib/agent-harness/kilo-reads.test.ts(424 lines), covering scope, validation, deduplication, limits, empty results, and provider failures.Generated: 0 files changed.
Verification
No manual tests ran because this level adds adapters without activating the harness.
Composition, presentation, and live proof belong to later slices.
Visual Changes
Visual Changes: N/A
Reviewer Notes
shared-agent-harness-3bb0-s18andshared-agent-harness-3bb0-s19.Kilo-Org/cloud; worktree:/Users/igor/Projects/.worktrees/shared-agent-harness-3bb0.git diff --check, including 141 pure tests.Human steps
No human steps are required before merge or after merge.
Notes
Runtime verification remains pending at the stack tip. This level adds named resource adapters without activating the harness.
Stacked PRs — merge bottom to top. Each level shows only its own diff.
Runtime verification (E2E, user advocacy, simplify) runs on the tip PR over every level.
Every level keeps its own checks, its own bot review, and its own threads; each one is answered on its own PR.
Each level is its own deliverable: it builds and passes its own checks alone.
A finding on a level is repaired on that level, then carried upward with stack.sh forward.
shared-agent-harness-3bb0— chore(agent-harness): register workspaces and enforce CI boundaries #5632shared-agent-harness-3bb0-s2— feat(agent-harness): define portable domain and snapshots #5637shared-agent-harness-3bb0-s3— feat(agent-harness): define commands tools and permission policy #5639shared-agent-harness-3bb0-s4— feat(agent-harness): share client state and cursor recovery #5643shared-agent-harness-3bb0-s5— feat(agent-harness): persist command intents and execution receipts #5647shared-agent-harness-3bb0-s6— feat(db): add harness ingress grants and retirement fences #5655shared-agent-harness-3bb0-s7— feat(agent-harness): deliver legacy history and project durable text #5659shared-agent-harness-3bb0-s8— feat(agent-harness): authorize durable grants and registered clients #5662shared-agent-harness-3bb0-s9— feat(agent-harness): fence retirement and retry payload cleanup #5667shared-agent-harness-3bb0-s10— feat(agent-harness): persist authoritative state in SQLite #5675shared-agent-harness-3bb0-s11— feat(agent-harness): admit durable runs and revisioned commands #5678shared-agent-harness-3bb0-s12— feat(agent-harness): recover queued runs and stream checkpointed steps #5688shared-agent-harness-3bb0-s13— feat(agent-harness): resolve interactions and dispatch tools sequentially #5693shared-agent-harness-3bb0-s14— feat(agent-harness): fence designated client tool execution #5697shared-agent-harness-3bb0-s15— feat(agent-harness): synchronize durable snapshots and legacy history #5701shared-agent-harness-3bb0-s16— feat(agent-harness): reuse authorized invitations with durable replay #5704shared-agent-harness-3bb0-s17— feat(integrations): bound repository transport for harness reads #5710shared-agent-harness-3bb0-s18— feat(integrations): expose bounded authorized repository reads #5714shared-agent-harness-3bb0-s19— feat(agent-harness): expose named authorized resource reads #5718 ← this PRshared-agent-harness-3bb0-s20— feat(sessions): bound history transport for harness reads #5724shared-agent-harness-3bb0-s21— feat(agent-harness): read scoped Cloud Agent context and progress #5726 (tip)