Skip to content

feat(agent-harness): define portable domain and snapshots - #5637

Open
iscekic wants to merge 1 commit into
shared-agent-harness-3bb0from
shared-agent-harness-3bb0-s2
Open

feat(agent-harness): define portable domain and snapshots#5637
iscekic wants to merge 1 commit into
shared-agent-harness-3bb0from
shared-agent-harness-3bb0-s2

Conversation

@iscekic

@iscekic iscekic commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

No new behavior — this change adds data definitions without changing the running product.


Summary

ConversationSchema and PermissionModeSchema default missing settings to ask/revision 0; LegacyMessageSchema, MessageSchema, MessagePartSchema, ConversationProducer, and MessageProducer normalize legacy text without authority.
ProtocolVersionSchema, ContextSchema, ErrorSchema, WaitingSchema, RunStateSchema, RunSchema, ToolOutcomeSchema, ExecutionTargetSchema, ApprovalRecordSchema, and ToolCallSchema validate portable recovery records and preserve complete tool calls.
InteractionSchema, ClientSchema, ExecutionGrantSchema, PendingClientActionSchema, SnapshotSchema, EventEnvelopeSchema, HistoryCursorSchema, and EventCursorSchema preserve recovery state; callers must authenticate producers that claim harness provenance.

Files
  • packages/agent-harness/src/contracts.ts — added (A; source; +271/−0 lines). Reuses gateway context directly to avoid Web globals. Adds protocol, identifier, timestamp, error, and strict variant validation. Keeps owner and legacy message client identifiers as strings. Permissions allow ask or yolo. Runs retain origin, model, and variant metadata; waiting and failed states require their payloads. Freezes validated tool records, contexts, targets, approvals, and nested arguments. Calls retain definitions, effects, approvals, and backend/client/interaction targets; results exist exactly when settled. Outcomes distinguish success, failure, denial, cancellation, and uncertainty, including reasons and optional provider references. Interactions retain approval decisions or question answers and dismissals. Browser/mobile clients retain supported tool versions and revocation times. Grants bind the owner, conversation, client, call, context, definition, input digest, generation, and expiry. Pending actions require client targets and retain their blocking reason and nullable grant. Harness messages require the protocol version and run identity; tool parts retain complete records without extra lookups. Citations allow only http/https URLs. Missing message fields default to text parts, clientId: null, and harness incomplete: false. Legacy parsing discards supplied authority and parts; compatibility defaults remain until old records and callers disappear. Snapshots require recovery fields independently of recent messages, including opaque history cursors, pending actions, and unresolved interactions. Active runs must be running, waiting, or stopping; queued runs must be queued. Events carry conversation, message, run, interaction, or nullable client-action payloads. Event cursors accept zero, while event sequences require positive integers. Exports the normalized Conversation, Message, Run, ToolCall, ToolOutcome, Interaction, Client, ExecutionGrant, Snapshot, and EventEnvelope types separately from producer inputs.

Tests: 1 file added (A; test; +410/−0 lines): packages/agent-harness/src/contracts.test.ts. Covers normalization, serialization, authority retention, immutability, recovery fields, and invalid variants. The handoff reports 114 passing contract tests and passing scoped checks.
Generated: 0 files changed.


Verification

No manual tests ran for this description. This level adds inert portable schemas only.

Visual Changes

Visual Changes: N/A

Reviewer Notes

Human steps

No human steps are required before or after merge.

Scope and worktrees

  • Repository: Kilo-Org/cloud.
  • Worktree: /Users/igor/Projects/.worktrees/shared-agent-harness-3bb0.
  • Branch: shared-agent-harness-3bb0-s2; base: origin/shared-agent-harness-3bb0.
  • Scope: Level 2 portable schemas only; this change adds no runtime or hosts.

Notes

E2E: This level adds inert portable schemas only. Full runtime verification runs on the completed stack tip.

Stacked PRs — merge bottom to top. Each level shows only its own diff.

Runtime verification (E2E, user advocacy, simplify) runs on the tip PR over every level.
Every level keeps its own checks, its own bot review, and its own threads; each one is answered on its own PR.
Each level is its own deliverable: it builds and passes its own checks alone.
A finding on a level is repaired on that level, then carried upward with stack.sh forward.

  1. shared-agent-harness-3bb0chore(agent-harness): register workspaces and enforce CI boundaries #5632
  2. shared-agent-harness-3bb0-s2feat(agent-harness): define portable domain and snapshots #5637 ← this PR
  3. shared-agent-harness-3bb0-s3feat(agent-harness): define commands tools and permission policy #5639
  4. shared-agent-harness-3bb0-s4feat(agent-harness): share client state and cursor recovery #5643
  5. shared-agent-harness-3bb0-s5feat(agent-harness): persist command intents and execution receipts #5647 (tip)

@kilo-code-bot

kilo-code-bot Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (2 files)
  • packages/agent-harness/src/contracts.ts
  • packages/agent-harness/src/contracts.test.ts

Reviewed by grok-4.6 · Input: 110.4K · Output: 23.7K · Cached: 553.7K

Review guidance: REVIEW.md from base branch shared-agent-harness-3bb0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant