fix: improve probabilistic SEG legend usability (#409) - #410
Open
igoroctaviano wants to merge 7 commits into
Open
fix: improve probabilistic SEG legend usability (#409)#410igoroctaviano wants to merge 7 commits into
igoroctaviano wants to merge 7 commits into
Conversation
Bump dicom-microscopy-viewer to the slim#409 fix so the probabilistic SEG/parametric-map legend is collapsible, hidden when no overlay is visible, and stays in sync with right-panel visibility toggles.
6 tasks
 |
|
Overall Grade |
Security Reliability Complexity Hygiene |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| JavaScript |  |
Aug 7, 2026 3:14p.m. | Review ↗ |
Important
AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.
Drop --ignore-scripts on PR workflows so prepare can emit dist/, clean allowBuilds, and point at the refreshed fix/409-collapsible-seg-legend tip.
The post-merge tip failed webpack during prepare (missing dataLoader.worker.min.js). Keep workflows without --ignore-scripts and pin 1023019, which still includes the collapsible legend fix.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| run: pnpm install --frozen-lockfile --ignore-scripts | ||
| # Dependency build scripts are gated by allowBuilds in pnpm-workspace.yaml. | ||
| # The git-hosted dicom-microscopy-viewer needs its prepare script to build dist/. | ||
| run: pnpm install --frozen-lockfile |
| run: pnpm install --frozen-lockfile --ignore-scripts | ||
| # Dependency build scripts are gated by allowBuilds in pnpm-workspace.yaml. | ||
| # The git-hosted dicom-microscopy-viewer needs its prepare script to build dist/. | ||
| run: pnpm install --frozen-lockfile |
| run: pnpm install --frozen-lockfile --ignore-scripts | ||
| # Dependency build scripts are gated by allowBuilds in pnpm-workspace.yaml. | ||
| # The git-hosted dicom-microscopy-viewer needs its prepare script to build dist/. | ||
| run: pnpm install --frozen-lockfile |
Pull in the babel include: context fix so prepare succeeds when pnpm builds the git dependency inside a store path containing node_modules.
|
Visit the preview URL for this PR (updated for commit 9b5cb03): https://idc-external-006--pr410-fix-409-collapsible-qv2zq2pc.web.app (expires Fri, 14 Aug 2026 15:16:18 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 88aacecd98ba54d2f9c8d201a9444e43d1ad8307 |
Compose marks the app started before nginx is listening, so a bare curl right after `up -d` flakes. Match the DICOMweb poll pattern.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #409.
Companion to dicom-microscopy-viewer#275.
dicom-microscopy-viewer@1023019(fix/409-collapsible-seg-legend) via GitHub so the in-viewport fractional SEG / parametric-map legend:Notes
Test plan
pnpm installbuilds dmvdist/via preparepnpm test— 5 suites / 39 tests passed