Fix IgbTab.EnsureModulesLoaded to register parent IgbTabsModule - #357
Merged
damyanpetev merged 3 commits intoAug 21, 2026
Merged
Conversation
Co-authored-by: damyanpetev <3198469+damyanpetev@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update missed IgbTab child-component case in EnsureModulesLoaded
Fix IgbTab.EnsureModulesLoaded to register parent IgbTabsModule
Aug 20, 2026
damyanpetev
changed the base branch from
master
to
dpetev/child-modules-cleanup
August 21, 2026 06:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #317's child-module cleanup missed
IgbTab: itsEnsureModulesLoadedstill resolved its ownIgbTabModuleinstead of the parentIgbTabsModule, inconsistent with the pattern applied to other child components in that effort.Changes
IgbTab.EnsureModulesLoadednow checks/registersIgbTabsModule(the parent) instead ofIgbTabModule(its own), matching the established lazy-registration pattern used by other child components (e.g.IgbCardActions→IgbCardModule,IgbRatingSymbol→IgbRatingModule).protected override void EnsureModulesLoaded() { - if (!IgbTabModule.IsLoadRequested(IgBlazor)) + if (!IgbTabsModule.IsLoadRequested(IgBlazor)) { - IgbTabModule.Register(IgBlazor); + IgbTabsModule.Register(IgBlazor); } }IgbTabsModule.Registeralready loads the underlying web module and marks the child module as requested, so routing through the parent avoids duplicate/inconsistent module resolution for a component that never renders standalone outsideIgbTabs.