Skip to content

Fix IgbTab.EnsureModulesLoaded to register parent IgbTabsModule - #357

Merged
damyanpetev merged 3 commits into
dpetev/child-modules-cleanupfrom
copilot/update-igbtab-module-correction
Aug 21, 2026
Merged

Fix IgbTab.EnsureModulesLoaded to register parent IgbTabsModule#357
damyanpetev merged 3 commits into
dpetev/child-modules-cleanupfrom
copilot/update-igbtab-module-correction

Conversation

Copilot AI commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

PR #317's child-module cleanup missed IgbTab: its EnsureModulesLoaded still resolved its own IgbTabModule instead of the parent IgbTabsModule, inconsistent with the pattern applied to other child components in that effort.

Changes

  • IgbTab.EnsureModulesLoaded now checks/registers IgbTabsModule (the parent) instead of IgbTabModule (its own), matching the established lazy-registration pattern used by other child components (e.g. IgbCardActionsIgbCardModule, IgbRatingSymbolIgbRatingModule).
 protected override void EnsureModulesLoaded()
 {
-    if (!IgbTabModule.IsLoadRequested(IgBlazor))
+    if (!IgbTabsModule.IsLoadRequested(IgBlazor))
     {
-        IgbTabModule.Register(IgBlazor);
+        IgbTabsModule.Register(IgBlazor);
     }
 }

IgbTabsModule.Register already loads the underlying web module and marks the child module as requested, so routing through the parent avoids duplicate/inconsistent module resolution for a component that never renders standalone outside IgbTabs.

Co-authored-by: damyanpetev <3198469+damyanpetev@users.noreply.github.com>
Copilot AI changed the title [WIP] Update missed IgbTab child-component case in EnsureModulesLoaded Fix IgbTab.EnsureModulesLoaded to register parent IgbTabsModule Aug 20, 2026
Copilot AI requested a review from damyanpetev August 20, 2026 16:57
@damyanpetev
damyanpetev changed the base branch from master to dpetev/child-modules-cleanup August 21, 2026 06:03
@damyanpetev
damyanpetev marked this pull request as ready for review August 21, 2026 06:45
@damyanpetev
damyanpetev merged commit e7b436e into dpetev/child-modules-cleanup Aug 21, 2026
@damyanpetev
damyanpetev deleted the copilot/update-igbtab-module-correction branch August 21, 2026 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants