Fix IgbTab child component to register parent IgbTabsModule - #356
Closed
damyanpetev with Copilot wants to merge 2 commits into
Closed
Fix IgbTab child component to register parent IgbTabsModule#356damyanpetev with Copilot wants to merge 2 commits into
damyanpetev with Copilot wants to merge 2 commits into
Conversation
Co-authored-by: damyanpetev <3198469+damyanpetev@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix IgbTab child-component module registration
Fix IgbTab child component to register parent IgbTabsModule
Aug 20, 2026
Member
|
dupe of #357 cuz of agents outage & resend |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IgbTab(child ofIgbTabs) registered its own, redundant module instead of its parent's — the same anti-pattern addressed for other child-component families (e.g.IgbRatingSymbol→IgbRating,IgbCardActions→IgbCard), but missed for the Tabs family.Change
IgbTab.EnsureModulesLoadednow targets the parentIgbTabsModuleinstead of the self-referentialIgbTabModule, matching the established lazy-registration convention (IgbTabsModule.Registeralready marksIgbTabModuleas loaded internally).No other files touched —
IgbTabModuleandIgbTabsModulethemselves are unrelated to this fix.