Skip to content

Fix IgbTab child component to register parent IgbTabsModule - #356

Closed
damyanpetev with Copilot wants to merge 2 commits into
masterfrom
copilot/fix-igbtab-child-component-registration
Closed

Fix IgbTab child component to register parent IgbTabsModule#356
damyanpetev with Copilot wants to merge 2 commits into
masterfrom
copilot/fix-igbtab-child-component-registration

Conversation

Copilot AI commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

IgbTab (child of IgbTabs) registered its own, redundant module instead of its parent's — the same anti-pattern addressed for other child-component families (e.g. IgbRatingSymbolIgbRating, IgbCardActionsIgbCard), but missed for the Tabs family.

Change

  • IgbTab.EnsureModulesLoaded now targets the parent IgbTabsModule instead of the self-referential IgbTabModule, matching the established lazy-registration convention (IgbTabsModule.Register already marks IgbTabModule as loaded internally).
protected override void EnsureModulesLoaded()
{
    if (!IgbTabsModule.IsLoadRequested(IgBlazor))
    {
        IgbTabsModule.Register(IgBlazor);
    }
}

No other files touched — IgbTabModule and IgbTabsModule themselves are unrelated to this fix.

Co-authored-by: damyanpetev <3198469+damyanpetev@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix IgbTab child-component module registration Fix IgbTab child component to register parent IgbTabsModule Aug 20, 2026
Copilot AI requested a review from damyanpetev August 20, 2026 16:58
@damyanpetev

Copy link
Copy Markdown
Member

dupe of #357 cuz of agents outage & resend

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants