Fix getTypeNameWithGenerics for package-qualified type arguments - #27
Merged
Merged
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overall this is a well-structured fix with good test coverage. The parsing logic in getTypeNameWithGenerics is sound and handles the complex type syntax correctly. One defensive guard for empty partName after package stripping would make it more robust. A few minor suggestions inline.
hi-rai
force-pushed
the
dev/himanshu/fix-get-type-name-with-generics
branch
from
August 19, 2026 10:51
c86438a to
13a144d
Compare
satvik007
requested changes
Sep 22, 2026
satvik007
left a comment
satvik007
left a comment
Collaborator
There was a problem hiding this comment.
Can we have a better way to handle name clashes, when 2 structs have same name but they are present in different packages.
Contributor
Author
The issue already exists for non-generic types and should be fixed separately. I will open a separate PR for that |
satvik007
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generic type arguments containing defined types included package paths and compiler-generated suffixes in generated schema names, producing invalid or unstable TypeScript identifiers. This change strips package qualifiers and compiler suffixes while retaining nested generic argument names.
For example:
GenericPair[int,github.com/example/models.User]previously generated:GenericPairIntGithubComExampleModelsUserSchema. It now generates:GenericPairIntUserSchema