Properly handle same name types from different packages - #29
Merged
Merged
Conversation
Base automatically changed from
dev/himanshu/fix-get-type-name-with-generics
to
main
September 25, 2026 08:37
hi-rai
force-pushed
the
dev/himanshu/type-name-clashes
branch
from
September 25, 2026 08:59
1e6fc43 to
b4e95a6
Compare
satvik007
approved these changes
Sep 25, 2026
Comment on lines
+386
to
+390
| c.Convert(Account{ | ||
| Owner api.User | ||
| Record db.User | ||
| History Page[db.User] | ||
| }) |
Collaborator
There was a problem hiding this comment.
This probably won't compile
It should declare the struct first, then convert it:
type Account struct {
Owner api.User
Record db.User
History Page[db.User]
}
c.Convert(Account{})
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed: Added schema name collision detection and
WithPackagePrefixesto distinguish types from different packages. Fixed generic type naming and added regression coverage for Zod v3 and v4.Why: Types with the same name could silently reuse an incorrect schema, while package-qualified generic arguments could produce invalid TypeScript identifiers.
Impact: Name collisions now cause a clear panic. Applications with conflicting type names must configure package prefixes. Anonymous structs require
AddTypeWithNamewith a non-empty name.Fixes #27 (comment)