Skip to content

fix: Global well residual norm calc #4100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tjb-ltk wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

fix: Global well residual norm calc #4100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
aafd403
dont set residual tracking var to zero when processing shut well
tjb-ltk Jul 21, 2026
b186e15
baseline update for 2 models
tjb-ltk Jul 21, 2026
94d74b5
missing digit
tjb-ltk Jul 22, 2026
01c0906
Merge branch 'develop' into fix/byer3/wellresidual_shutwell
tjb-ltk Jul 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .integrated_tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
baselines:
bucket: geosx
baseline: integratedTests/baseline_integratedTests-pr3836-17046-2e89f64
baseline: integratedTests/baseline_integratedTests-pr4100-17125-aafd403

allow_fail:
all: ''
Expand Down
4 changes: 3 additions & 1 deletion BASELINE_NOTES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,10 @@ This file is designed to track changes to the integrated test baselines.
Any developer who updates the baseline ID in the .integrated_tests.yaml file is expected to create an entry in this file with the pull request number, date, and their justification for rebaselining.
These notes should be in reverse-chronological order, and use the following time format: (YYYY-MM-DD).

PR #4100 (2026-07-22) <https://storage.googleapis.com/geosx/integratedTests/baseline_integratedTests-pr4100-17125-aafd403.tar.gz>
Fix to include all well residuals in convergence check.

PR #3836 (2026-05-20) <https://storage.googleapis.com/geosx/integratedTests/baseline_integratedTests-pr3836-17046-2e89f64.tar.gz>
=====================
Added statistics `Group` objects for each statistics `Task` instance

PR #4040 (2026-06-16) <https://storage.googleapis.com/geosx/integratedTests/baseline_integratedTests-pr4040-16993-1393f80.tar.gz>
Expand Down
1 change: 0 additions & 1 deletion src/coreComponents/physicsSolvers/fluidFlow/wells/CompositionalMultiphaseWell.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1443,7 +1443,6 @@ CompositionalMultiphaseWell::calculateResidualNorm( real64 const & time_n,
{
for( integer i = 0; i < numNorm; ++i )
{
localResidualNorm[i] = 0.0;
localResidualNormalizer[i] = m_nonlinearSolverParameters.m_minNormalizer;
}
}
Expand Down