fix: Global well residual norm calc#4100
Open
tjb-ltk wants to merge 4 commits into
Open
Conversation
tjb-ltk
requested review from
OmarDuran,
dkachuma,
jhuang2601 and
rrsettgast
as code owners
July 21, 2026 18:51
tjb-ltk
added
type: bug
Contributor
Author
|
@victorapm @jafranc This is a fix for the bug you found in the wm_we branch. It's probably better if it has dedicated PR to isolate changes in baselines for fixes that change behavior. GEOS branch doesn't have a unified treatment of shut wells so only change is in compositional. The 2 models with differences in this PR show differences in wm_we branch. |
jafranc
approved these changes
Jul 23, 2026
victorapm
approved these changes
Jul 23, 2026
victorapm
left a comment
victorapm
left a comment
Contributor
There was a problem hiding this comment.
Looks great, thanks Tom!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If an open well had non converged residual followed by a shut well, the max well residual was set to zero, allowing global convergence with a non converged well, this is only an issue for compositional models. The non convergence would be in the well segment flows. Checks on material balance for reservoir cells with well perforations is not impacted by this bug.