Fix NPC "Selected" variable defaulting to true in the point-and-click adventures - #1035
Merged
Merged
Conversation
…tures With Selected true on every NPC from the start, the dialog opens on the first frame when the player spawns overlapping an NPC (and the Pathfinding behavior is deactivated) before any input, in the 2D adventure. The 3D variant carries the same wrong default and only escapes the symptom thanks to its spawn position. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AaQQdPZ68X8zkybtsxWE1b
Contributor
Preview the game(s) changed or added in this Pull Request
This is an automatic message displaying links to the games in this PR - double check the JSON in case of doubt. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while writing gameplay tests: in
starting-point-and-click-adventure, theNPCobject'sSelectedboolean variable defaults to true. Since the player spawns overlapping two NPCs, the collision event fires on the very first frame — the dialog layer is shown and the Pathfinding behavior deactivated before any input, so the game opens with a dialog up and the player frozen.