Drop the adventure dialog workaround, and screenshot five more tests

[4ian]

Follow-up to #1034, on top of #1035 (NPC.Selected no longer defaults to true).

The point-and-click adventure no longer needs its workaround

Both of its tests used to dismiss a dialog with "no" before they could do anything: the player spawned overlapping two NPCs that counted as being talked to, so the level opened with the dialog up and the player frozen. With #1035 in, the level starts clean — verified: dialog=false act=true on the first frames.

The workaround is gone from both tests. What replaces it is an assertion rather than nothing, so the fixed default is now covered:

// Nobody is being talked to when the level starts: the dialog below can only
// come from the click.
harness.assert(!isDialogOpen(), 'No dialog is open before talking to anyone.');

That trims the walking test from 112 to 100 lines and the talking one from 78 to 70, and both got faster (the walking test went from 71 to 63 stepped frames).

One thing that did not change: the talking test still uses an NPC the player already stands next to, rather than walking across the level to a distant one. That is not left over from the bug — the player's bounding box is 310×510 in a 1280×720 level, so it overlaps NPCs from a long way off (it still touches one at 312px away). Reaching a "distant" NPC would be walking a handful of pixels, so clicking a neighbour is the honest version. The 3D adventure, whose objects are sensibly sized, does test the walk.

Screenshots on five more tests

Still one test out of the two in each game:

Game	Test	What it shows
starting-point-and-click-adventure	Talking to an NPC and saying yes	the scene once the NPC has left
starting-3d-point-and-click-adventure	Talking to an NPC and saying yes	same, in 3D
starting-first-person-survival-crafting	Harvesting a tree fills the inventory	the inventory slot holding the log, counted 1
starting-card-game	Drawing a card from the deck	the drawn card in front of the deck
starting-beatemup	Attacking hits the enemy	the enemy taking the hit

That makes 15 games with a screenshot, out of 45.

All 10 tests of the five games pass. The screenshots are 9–17 KB each and cost a couple of seconds at most: starting-3d-point-and-click-adventure's test measured 28.0s once, which looked alarming, but three further runs gave 11.5s, 14.0s and 18.6s against a ~11s baseline — that was a loaded machine, not the screenshot.

🤖 Generated with Claude Code

https://claude.ai/code/session_01M2jc7PVAvmMmirAQude2v1

---

Generated by Claude Code

[github-actions]

Preview the game(s) changed or added in this Pull Request

• https://editor.gdevelop.io?project=https://raw.githubusercontent.com/GDevelopApp/GDevelop-examples/claude/gameplay-tests-starters-6jb8r0/examples/starting-3d-point-and-click-adventure/starting-3d-point-and-click-adventure.json
• https://editor.gdevelop.io?project=https://raw.githubusercontent.com/GDevelopApp/GDevelop-examples/claude/gameplay-tests-starters-6jb8r0/examples/starting-beatemup/starting-beatemup.json
• https://editor.gdevelop.io?project=https://raw.githubusercontent.com/GDevelopApp/GDevelop-examples/claude/gameplay-tests-starters-6jb8r0/examples/starting-card-game/starting-card-game.json
• https://editor.gdevelop.io?project=https://raw.githubusercontent.com/GDevelopApp/GDevelop-examples/claude/gameplay-tests-starters-6jb8r0/examples/starting-first-person-survival-crafting/starting-first-person-survival-crafting.json
• https://editor.gdevelop.io?project=https://raw.githubusercontent.com/GDevelopApp/GDevelop-examples/claude/gameplay-tests-starters-6jb8r0/examples/starting-point-and-click-adventure/starting-point-and-click-adventure.json

---

This is an automatic message displaying links to the games in this PR - double check the JSON in case of doubt.