Skip to content

Fix crash when calling back a missed call with a stale SIM handle #849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bilec wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −4
Open

Fix crash when calling back a missed call with a stale SIM handle #849

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [Unreleased]
### Fixed
- Fixed crash when tapping "Call back" on a missed call notification when the phone account handle from the intent no longer resolves (e.g. an inactive/locked SIM) ([#134], [#473])

## [1.11.1] - 2026-02-01
### Changed
Expand Down Expand Up @@ -243,6 +245,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
[#118]: https://github.com/FossifyOrg/Phone/issues/118
[#125]: https://github.com/FossifyOrg/Phone/issues/125
[#133]: https://github.com/FossifyOrg/Phone/issues/133
[#134]: https://github.com/FossifyOrg/Phone/issues/134
[#139]: https://github.com/FossifyOrg/Phone/issues/139
[#146]: https://github.com/FossifyOrg/Phone/issues/146
[#147]: https://github.com/FossifyOrg/Phone/issues/147
Expand All @@ -260,6 +263,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
[#359]: https://github.com/FossifyOrg/Phone/issues/359
[#378]: https://github.com/FossifyOrg/Phone/issues/378
[#389]: https://github.com/FossifyOrg/Phone/issues/389
[#473]: https://github.com/FossifyOrg/Phone/issues/473
[#526]: https://github.com/FossifyOrg/Phone/issues/526
[#535]: https://github.com/FossifyOrg/Phone/issues/535
[#543]: https://github.com/FossifyOrg/Phone/issues/543
Expand Down
7 changes: 3 additions & 4 deletions app/src/main/kotlin/org/fossify/phone/extensions/CallExt.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,12 +106,11 @@ fun SimpleActivity.getHandleToUse(
if (it) {
val defaultHandle =
telecomManager.getDefaultOutgoingPhoneAccount(PhoneAccount.SCHEME_TEL)
// hasExtra() can be true with a null parcelable (e.g. locked SIM); extract safely and fall through.
val intentHandle = intent?.getParcelableExtra<PhoneAccountHandle>(TelecomManager.EXTRA_PHONE_ACCOUNT_HANDLE)
when {
forceSimSelector -> showSelectSimDialog(phoneNumber, callback)
intent?.hasExtra(TelecomManager.EXTRA_PHONE_ACCOUNT_HANDLE) == true -> {
callback(intent.getParcelableExtra(TelecomManager.EXTRA_PHONE_ACCOUNT_HANDLE)!!)
}

intentHandle != null -> callback(intentHandle)
config.getCustomSIM(phoneNumber) != null -> {
callback(config.getCustomSIM(phoneNumber))
}
Expand Down
Loading