Fix crash when calling back a missed call with a stale SIM handle#849
Open
bilec wants to merge 1 commit into
Open
Fix crash when calling back a missed call with a stale SIM handle#849bilec wants to merge 1 commit into
bilec wants to merge 1 commit into
Conversation
Intent.hasExtra(EXTRA_PHONE_ACCOUNT_HANDLE) only confirms the key is present, not that the parcelable resolves to a non-null value. When the handle points to a SIM slot that's present but inactive/locked, getParcelableExtra() can return null and the !! throws an NPE. Extract the extra defensively and fall back to the existing options (saved custom SIM, default outgoing account, SIM selector dialog) instead of crashing. Fixes FossifyOrg#134 Fixes FossifyOrg#473
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent.hasExtra(EXTRA_PHONE_ACCOUNT_HANDLE) only confirms the key is present, not that the parcelable resolves to a non-null value. When the handle points to a SIM slot that's present but inactive/locked, getParcelableExtra() can return null and the !! throws an NPE.
Extract the extra defensively and fall back to the existing options (saved custom SIM, default outgoing account, SIM selector dialog) instead of crashing.
Type of change(s)
What changed and why
getHandleToUse()usedintent.getParcelableExtra(EXTRA_PHONE_ACCOUNT_HANDLE)!!after only checkinghasExtra(), which doesn't guarantee the parcelable actually resolves to a non-null handlegetParcelableExtra()returns null, and!!throws an NPE toast when tapping "Call back" on a missed-call notificationwhenfallbacks (saved custom SIM → default outgoing account → SIM selector dialog) instead of crashingTests performed
Closes the following issue(s)
Checklist
CHANGELOG.md(if applicable).