-
Notifications
You must be signed in to change notification settings - Fork 4
fix(ci): use PAT when filing scenario reports so project workflows run #97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -498,7 +498,11 @@ jobs: | |
| if: always() && steps.should_file.outputs.file == 'true' && inputs.enable_reporting | ||
| uses: ipdxco/create-or-update-issue@v1 | ||
| with: | ||
| GITHUB_TOKEN: ${{ github.token }} | ||
| # We're not using `github.token` here because it won't trigger other workflows like `add-issues-to-project`. | ||
| # Instead, we use a PAT to trigger other workflows. | ||
| # This PAT has permissions to open/update issues, which is why it was used. | ||
| # Alternatively, we could create a more narrowly scoped PAT, but this would be another PAT to setup/manage. | ||
| GITHUB_TOKEN: ${{ secrets.FILOZZY_RELEASE_PLEASE_PAT_FILOZONE }} | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Looks like the secret is not configured for this repo.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @galargh : Doh - you're right
Fixed now at https://github.com/organizations/FilOzone/settings/secrets/actions/FILOZZY_RELEASE_PLEASE_PAT Confirmed at https://github.com/FilOzone/foc-devnet/settings/secrets/actions |
||
| title: ${{ inputs.issue_title }} | ||
| body: | | ||
| The **${{ inputs.name }}** scenarios run **${{ steps.should_file.outputs.passed == 'true' && 'passed ✅' || 'failed ❌' }}**. | ||
|
|
||

There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't really make sense.