Skip to content

fix(ci): use PAT when filing scenario reports so project workflows run#97

Merged
BigLep merged 1 commit intomainfrom
fix/ci-scenario-issue-pat-for-downstream-workflows
Mar 27, 2026
Merged

fix(ci): use PAT when filing scenario reports so project workflows run#97
BigLep merged 1 commit intomainfrom
fix/ci-scenario-issue-pat-for-downstream-workflows

Conversation

@BigLep
Copy link
Copy Markdown
Contributor

@BigLep BigLep commented Mar 27, 2026

Problem

Nightly scenario reporting (via ci_nightly.yml → reusable ci_run.yml) creates or updates GitHub issues for runs like the frontier/stability reports (similar in spirit to foc-devnet#96).

The Add issues and PRs to FS project board workflow (and other issues: opened automation) was not running for those issues.

Per GitHub Actions behavior, events triggered with the default GITHUB_TOKEN / github.token do not start other workflows (except cases such as workflow_dispatch / repository_dispatch). So ipdxco/create-or-update-issue using github.token produced issue activity that did not cascade to org/repo workflows that listen for new issues.

Specifically I want it so future issues like #95 and #96 show up on our project board.

Change

  • Use secrets.FILOZZY_RELEASE_PLEASE_PAT_FILOZONE as the token passed to create-or-update-issue so issue open/update behaves like normal bot/user API activity and downstream workflows can run.
  • ci_nightly.yml and ci_pull_request.yml already call the reusable workflow with secrets: inherit; no caller changes.

Notes from code review (inline comments in ci_run.yml)

  • We avoid github.token here because it does not trigger other workflows such as add-issues-to-project-style automation.
  • A PAT is used so those workflows do run.
  • The chosen PAT already has permission to open/update issues; a narrower-scoped PAT would be possible but adds another secret to set up and manage.

Checklist

  • Confirm FILOZZY_RELEASE_PLEASE_PAT_FILOZONE is configured for FilOzone/foc-localnet (or inherited from org) with sufficient scopes to create/update issues and labels in this repo.

Made with Cursor

GitHub suppresses workflows triggered by the default GITHUB_TOKEN, so
issues opened via create-or-update-issue did not fire listeners such as
add-issues-and-prs-to-fs-project-board. Use FILOZZY_RELEASE_PLEASE_PAT_FILOZONE
so issue-open events behave like normal user/bot activity.

Callers already use secrets: inherit; ensure the secret is available on this repo.

Made-with: Cursor
Copilot AI review requested due to automatic review settings March 27, 2026 16:36
@FilOzzy FilOzzy added this to FOC Mar 27, 2026
@github-project-automation github-project-automation bot moved this to 📌 Triage in FOC Mar 27, 2026
@BigLep BigLep requested a review from rjan90 March 27, 2026 16:36
@BigLep BigLep moved this from 📌 Triage to 🔎 Awaiting review in FOC Mar 27, 2026
@BigLep
Copy link
Copy Markdown
Contributor Author

BigLep commented Mar 27, 2026

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the reusable CI workflow to file/update scenario report issues using a Personal Access Token (PAT) instead of the default github.token, so that downstream automation workflows triggered by issues events (e.g., adding issues to a project board) will run as expected.

Changes:

  • Swap github.token for secrets.FILOZZY_RELEASE_PLEASE_PAT_FILOZONE when calling ipdxco/create-or-update-issue@v1.
  • Add inline documentation explaining why a PAT is required for cascading issues-triggered workflows.

@BigLep BigLep self-assigned this Mar 27, 2026
@github-project-automation github-project-automation bot moved this from 🔎 Awaiting review to ✔️ Approved by reviewer in FOC Mar 27, 2026
@BigLep BigLep merged commit c0aa6c8 into main Mar 27, 2026
7 of 8 checks passed
@github-project-automation github-project-automation bot moved this from ✔️ Approved by reviewer to 🎉 Done in FOC Mar 27, 2026
Comment on lines +501 to +502
# We're not using `github.token` here because it won't trigger other workflows like `add-issues-to-project`.
# Instead, we use a PAT to trigger other workflows.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't really make sense.

# Instead, we use a PAT to trigger other workflows.
# This PAT has permissions to open/update issues, which is why it was used.
# Alternatively, we could create a more narrowly scoped PAT, but this would be another PAT to setup/manage.
GITHUB_TOKEN: ${{ secrets.FILOZZY_RELEASE_PLEASE_PAT_FILOZONE }}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the secret is not configured for this repo.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🎉 Done

Development

Successfully merging this pull request may close these issues.

5 participants