Remove drive.ini; puffer_drive.yaml is the single config source - #539
Merged
Conversation
Since the Hydra switch, load_config composes puffer_drive.yaml — the ini files were dead config that still looked authoritative: editing them changed nothing at runtime, and their values silently diverged from the yaml. Delete both, along with the MANIFEST.in include that packaged them and the unused --config argument in metrics_sanity_check.py (load_config never read it). Comments, docstrings, error strings, and docs now point at puffer_drive.yaml; docs/evaluation.md's config-schema example is written in the yaml layout instead of ini sections. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
riccardosavorgnan
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deletes
pufferlib/config/ocean/drive.iniandpufferlib/config/default.ini, and repoints every reference atpufferlib/config/puffer_drive.yamlsince that is now the new default yaml