Bernhard 01#536
Open
Kait0 wants to merge 33 commits into
Open
Conversation
…ent is continuous.
… into bernhard_01
…rything mode for now.
… into bernhard_01
|
You can just remove the files from the git commit, no? Is there an issue that I'm not seeing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the option to make the policy use either the mean, the mode, or a sample of the distribution instead of the mode during inference.
This required a fundamental design change.
Previously, the action representation was hardcoded in the simulator.
Now there are two options: one for the agent, either continuous or discrete, and one for the environment, either continuous or discrete (to avoid removing features).
The default now is:
env.action_type: continuous
policy.action_type: discrete
The default for eval is kept in mode so that there is no change in behavior with the default configuration.
In local eval eval_simulation: gigaflow
and default parameters, this improved the latest nightly model slightly:
mean: "avg_distance_per_infraction": 16646
mode: "avg_distance_per_infraction": 16127
The pull request also includes some of my cluster files for nodes and job submissions.
Not sure if there is a way to exclude them from the merge. If anybody knows, let me know. Otherwise they won't be in the way.
This is my first pull request. Ideally, somebody familiar with the repo should review it. We can also do a meeting.