Fix Scoop shim failure under RedirectionGuard by retrying elevated#4899
Merged
Conversation
4 tasks
Marc-André Moreau (mamoreau-devolutions)
approved these changes
Jun 8, 2026
4 tasks
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves how the Scoop package manager handles shim creation failures that require elevation, and adds tests to ensure this behavior works as expected. The main change is to automatically retry failed shim operations with elevated privileges if a specific error is detected, preventing unnecessary failures and improving reliability.
Scoop shim error handling:
ScoopPkgOperationHelper.csto detect shim resolution failures (messages containing "Can't shim") and automatically retry the operation with elevated privileges, unless already running as administrator. This prevents failures caused by permission issues when creating shims.Test coverage improvements:
ScoopManagerTests.csto verify: