Fix Scoop shim failure under RedirectionGuard by retrying elevated

src/UniGetUI.PackageEngine.Managers.Scoop/Helpers/ScoopPkgOperationHelper.cs

@@ -1,3 +1,4 @@
+using UniGetUI.Core.SettingsEngine;
 using UniGetUI.PackageEngine.Classes.Manager.BaseProviders;
 using UniGetUI.PackageEngine.Enums;
 using UniGetUI.PackageEngine.Interfaces;
@@ -114,6 +115,18 @@ int returnCode
             return OperationVeredict.AutoRetry;
         }
 
+        // Scoop can't resolve shims through the fresh 'current' junction in some contexts; an elevated (trusted) junction fixes it, so retry as admin unless elevation is disabled. See #4892
+        if (
+            package.OverridenOptions.RunAsAdministrator != true
+            && returnCode is not 0
+            && !Settings.Get(Settings.K.ProhibitElevation)
+            && output_string.Contains("Can't shim")
+        )
+        {
+            package.OverridenOptions.RunAsAdministrator = true;
+            return OperationVeredict.AutoRetry;
+        }
+
         if (output_string.Contains("ERROR") || returnCode is not 0)
             return OperationVeredict.Failure;
 

src/UniGetUI.PackageEngine.Tests/ScoopManagerTests.cs

@@ -301,6 +301,72 @@ public void OperationResultPromotesElevationRetryBeforeReturningFailure()
         OperationAssert.HasVeredict(success, OperationVeredict.Success);
     }
 
+    [Fact]
+    public void OperationResultRetriesElevatedOnShimResolutionFailure()
+    {
+        var manager = new Scoop();
+        var package = new PackageBuilder()
+            .WithManager(manager)
+            .WithOptions(new OverridenInstallationOptions(runAsAdministrator: false))
+            .Build();
+
+        var retry = manager.OperationHelper.GetResult(
+            package,
+            OperationType.Update,
+            ["Creating shim for 'notepad++'.", "Can't shim 'notepad++.exe': File doesn't exist."],
+            1
+        );
+
+        OperationAssert.HasVeredict(retry, OperationVeredict.AutoRetry);
+        Assert.True(package.OverridenOptions.RunAsAdministrator);
+
+        // Already elevated: the same failure must not loop, it should surface as a plain failure
+        var failure = manager.OperationHelper.GetResult(
+            package,
+            OperationType.Update,
+            ["Can't shim 'notepad++.exe': File doesn't exist."],
+            1
+        );
+        OperationAssert.HasVeredict(failure, OperationVeredict.Failure);
+    }
+
+    [Fact]
+    public void OperationResultDoesNotRetryShimMessageOnSuccess()
+    {
+        var manager = new Scoop();
+        var package = new PackageBuilder().WithManager(manager).Build();
+
+        var veredict = manager.OperationHelper.GetResult(
+            package,
+            OperationType.Update,
+            ["Creating shim for 'tool'.", "Can't shim is mentioned but the operation succeeded"],
+            0
+        );
+
+        OperationAssert.HasVeredict(veredict, OperationVeredict.Success);
+    }
+
+    [Fact]
+    public void OperationResultDoesNotElevateShimFailureWhenElevationProhibited()
+    {
+        Settings.Set(Settings.K.ProhibitElevation, true);
+        var manager = new Scoop();
+        var package = new PackageBuilder()
+            .WithManager(manager)
+            .WithOptions(new OverridenInstallationOptions(runAsAdministrator: false))
+            .Build();
+
+        var veredict = manager.OperationHelper.GetResult(
+            package,
+            OperationType.Update,
+            ["Can't shim 'notepad++.exe': File doesn't exist."],
+            1
+        );
+
+        OperationAssert.HasVeredict(veredict, OperationVeredict.Failure);
+        Assert.False(package.OverridenOptions.RunAsAdministrator);
+    }
+
     private static Scoop CreateManagerWithKnownSources(params string[] sourceNames)
     {
         var manager = new Scoop();