test: cover OTel deployment environment mapping [golang@brian.marks/otel-deployment-environment-name][dotnet@brian.marks/otel-deployment-environment-name][ruby@brian.marks/otel-deployment-environment-name][php@brian.marks/otel-deployment-environment-name][nodejs@brian.marks/otel-deployment-environment-name][rust@brian.marks/otel-deployment-environment-name]

[bm1549]

Motivation

Java and Python now map the stable OpenTelemetry resource attribute deployment.environment.name to the Datadog environment. The shared suite should enforce the same behavior as the remaining tracers add support.

Reference fixes:

• Support OpenTelemetry deployment environment names dd-trace-java#12324
• fix(config): support OTel deployment environment name dd-trace-py#19901

Changes

• Keep the existing, ungated legacy deployment.environment fallback test.
• Add config and emitted-span cases for each attribute alone, both attribute orders, and DD_ENV precedence.
• Check that unrelated resource attributes survive and that environment source attributes are consumed in the new cases.
• Gate each tracer on the first release that contains its implementation.

Coordinated tracer PRs:

• fix(config): support stable OTel deployment environment dd-trace-go#5285
• Support stable OTel deployment environment attribute dd-trace-dotnet#9150
• Add stable OTel environment attribute mapping dd-trace-rb#6261
• fix: support stable OTel deployment environment dd-trace-php#4148
• fix(config): prefer stable OTel deployment environment dd-trace-js#10050
• fix(config): map OTel deployment environment dd-trace-rs#300

Workflow

1. ⚠️ Create your PR as draft ⚠️
2. Work on your PR until the CI passes
3. Mark it as ready for review
   • Test logic is modified? -> Get a review from RFC owner.
   • Framework is modified, or its usage is non-obvious? -> Get a review from repository maintainers.

🚀 Once your PR is reviewed and the CI green, you can merge it!

Reviewer checklist

• Anything but tests/ or manifests/ is modified? I have approval from repository maintainers.
• A docker base image is modified?
  • the relevant build-XXX-image label is present
• A scenario is added, removed or renamed?
  • Get a review from repository maintainers.

[github-actions]

CODEOWNERS have been resolved as:

manifests/dotnet.yml                                                    @DataDog/system-tests-reviewers
manifests/golang.yml                                                    @DataDog/system-tests-reviewers
manifests/java.yml                                                      @DataDog/system-tests-reviewers
manifests/nodejs.yml                                                    @DataDog/system-tests-reviewers
manifests/php.yml                                                       @DataDog/system-tests-reviewers
manifests/python.yml                                                    @DataDog/system-tests-reviewers
manifests/ruby.yml                                                      @DataDog/system-tests-reviewers
manifests/rust.yml                                                      @DataDog/system-tests-reviewers
tests/parametric/test_otel_env_vars.py                                  @DataDog/system-tests-core @DataDog/apm-sdk-capabilities

[datadog-prod-us1-3]

 

⚠️ Warnings

❌ Your PR has failed checks. Please review the issues below and take necessary action before merging.

🚦 3 Pipeline jobs failed

Testing the test | Fail if target branch is specified

View more details · View in GitHub Actions

Merge blocked: title specifies a target branch.

Testing the test | System Tests (php, dev) / Get parameters / Get parameters

View more details · View in GitHub Actions

Error response from daemon: manifest unknown while extracting Docker base image 'ghcr.io/datadog/dd-trace-php/dd-library-php:brian-marks-otel-deployment-environment-name'.

Testing the test | all-jobs-are-green

View more details · View in GitHub Actions

Check Run Failed for specified target branch and System Tests.

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

Useful? React with 👍 / 👎

_{This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 7265826 | Docs | View more details | Give us feedback!}