fix(config): prefer stable OTel deployment environment - #10050
Merged
Conversation
bm1549
added
the
AI Generated
Contributor
Overall package sizeSelf size: 8.64 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 3.4.0 | 127.33 kB | 447.04 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | dc-polyfill | 0.1.11 | 25.74 kB | 25.74 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
This was referenced Aug 28, 2026
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: 1f96b1b | Docs | View more details | Give us feedback! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #10050 +/- ##
==========================================
- Coverage 98.63% 98.62% -0.01%
==========================================
Files 996 996
Lines 152275 152277 +2
Branches 13356 13243 -113
==========================================
- Hits 150193 150190 -3
- Misses 2082 2087 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
BenchmarksBenchmark execution time: 2026-09-01 22:09:54 Comparing candidate commit 1f96b1b in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 2297 metrics, 13 unstable metrics.
|
bm1549
force-pushed
the
brian.marks/otel-deployment-environment-name
branch
from
August 28, 2026 17:48
4d8a558 to
3f1fadb
Compare
bengl
previously requested changes
Sep 1, 2026
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
BridgeAR
approved these changes
Sep 1, 2026
BridgeAR
left a comment
BridgeAR
left a comment
Member
There was a problem hiding this comment.
The change is LGTM, while I believe this will not really change anything in reality 🤷
BridgeAR
pushed a commit
that referenced
this pull request
Sep 4, 2026
BridgeAR
pushed a commit
that referenced
this pull request
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Maps
deployment.environment.nameto the Datadog environment. The legacydeployment.environmentattribute remains a fallback, andDD_ENVstill wins.Motivation
OpenTelemetry stabilized the deployment environment semantic convention under
deployment.environment.name.Related PRs:
Additional Notes
Five focused tests and 324 adjacent configuration tests passed. The five existing pending tests remain pending. The full lint check also passed.