Skip to content

Pull request for feature/improvegitversioing #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
darthsharp merged 1 commit into from
Jun 5, 2025
Merged

Pull request for feature/improvegitversioing #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions builds/ci-build/src/build-it-lib/git/simple-git-version.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,8 @@ export class SimpleGitVersion {

this.applyBranchRule({
lastTag,
lastVersionFromTag: lastVersionFromTag,
commitCountSinceLastTag: commitCountSinceLastTag,
lastVersionFromTag,
commitCountSinceLastTag,
branchName,
branchRule,
version: newVersion,
Expand Down
6 changes: 5 additions & 1 deletion builds/ci-build/src/build-it-lib/tasks/npm-tasks.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,11 @@ export class NpmTasks extends BuildTasks {
await this.execute(async (buildContext) => {
const args = options.legacyPeerDeps ? ['--legacy-peer-deps'] : [];

await this.cmdExecutor.executeStream('npm ci', args);
if (this.context.isCI) {
await this.cmdExecutor.executeStream('npm ci', args);
} else {
await this.cmdExecutor.executeStream('npm install');
}
});
}

Expand Down
2 changes: 0 additions & 2 deletions builds/ci-build/src/build-it-lib/tasks/nx-tasks.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,6 @@ export class NxTasks extends BuildTasks {
'run',
`${projectName}:nx-release-publish`,
`--access ${access}`,
'--dryRun',
//'--registry=https://registry.npmjs.org/',
];

if (this.context.dryRun) {
Expand Down