Skip to content

fix(automation): replay isolated review-agent queues on current main - #835

Open
seonghobae wants to merge 5 commits into
mainfrom
fix/agent-mention-concurrency-current-main-20260808
Open

fix(automation): replay isolated review-agent queues on current main#835
seonghobae wants to merge 5 commits into
mainfrom
fix/agent-mention-concurrency-current-main-20260808

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

RCA

Protected main routes trusted interactive issue_comment requests and the five-minute organization sweep through one workflow-level concurrency group. GitHub permits one running and, by default, one pending member in a concurrency group; newer queued work can replace an existing pending run even when cancel-in-progress is false. A scheduled sweep can therefore discard a pending trusted @cwl-noema-review or review-only @opencode-agent request before exact-head resolution, durable-ledger claim, dispatch, or acknowledgement.

Historical PR #825 contains the bounded repair but is no longer mergeable and is based on protected-main 1131b1bbafb24e455fc8619cdf316813e8721861. Protected main advanced to 6eb06cdd08c79a06f7b390069d4ffa49e2eb7dba. No #825 check, review, approval, comment, or synthetic-merge evidence transfers here.

Feasibility decision

A destructive rebase/force-push is unnecessary. The old base → current-main delta modifies only the Strix quality lane, its doctoring/test, and one independent changelog entry; it does not touch the mention router or its tests. This replacement is rebuilt directly from exact current protected main and preserves the bounded five-file repair plus the intervening main changelog entry.

Bounded repair

  • remove the shared workflow-level concurrency group;
  • route trusted local comments under review-agent-mention-router-local-${{ github.repository }} with queue: max;
  • keep scheduled sweeps under review-agent-mention-router-sweep-${{ github.repository }} with cancel-in-progress: false;
  • preserve the canonical invocation key and exact-name 30-day Actions artifact ledger as the forwarding/idempotency authority;
  • preserve triggers, conditions, permissions, credential names/scopes, reviewer identities, repository allowlists, dispatch payloads, model routing, exact-head claims, and branch protection;
  • retain regression and operator/rollback evidence.

Exact replacement boundary

This branch is exactly five commits ahead and zero behind protected main at creation. The effective diff is limited to:

  • .github/workflows/agent-mention-router.yml
  • tests/test_agent_mention_workflow_contract.py
  • tests/test_agent_mention_artifact_ledger.py
  • docs/doctoring/agent-mention-concurrency-isolation.md
  • CHANGELOG.md

No predecessor evidence transfers. Keep Draft until implementation/tests/docs/changelog are complete and every currently executable exact-head deterministic/security/supply-chain gate is green with zero current source-backed findings. At that point Ready status is permitted solely to obtain current-head automated and independent review; Ready is not merge evidence. Merge remains prohibited until current automated review is complete, zero valid unresolved findings remain, a qualifying non-author counted approval exists, and branch protection/repository policy allow the exact unchanged head.

Operational acceptance

After protected integration, post fresh trusted Noema/OpenCode review-only comments and require durable receipt/acknowledgement and downstream dispatch. Verify a scheduled sweep cannot replace an interactive route. Static PR checks alone are not incident closure.

Supersedes #825 only after this replacement proves its own exact-head gates; #814 closes only after protected-main operational evidence.

@coderabbitai

coderabbitai Bot commented Aug 8, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 27 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: c06d94a3-cf6f-4678-9d8f-b4415d745985

📥 Commits

Reviewing files that changed from the base of the PR and between 6eb06cd and 4881c78.

📒 Files selected for processing (5)
  • .github/workflows/agent-mention-router.yml
  • CHANGELOG.md
  • docs/doctoring/agent-mention-concurrency-isolation.md
  • tests/test_agent_mention_artifact_ledger.py
  • tests/test_agent_mention_workflow_contract.py

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

Please review the unchanged exact head 4881c7860a1ed503917e68cc096dbfb1cdb75b36 against protected-base 6eb06cdd08c79a06f7b390069d4ffa49e2eb7dba. Focus on the bounded five-file agent-mention concurrency isolation repair; do not reuse predecessor #825 evidence.

@coderabbitai

coderabbitai Bot commented Aug 8, 2026

Copy link
Copy Markdown

@seonghobae I will review exact head 4881c7860a1ed503917e68cc096dbfb1cdb75b36 against protected base 6eb06cdd08c79a06f7b390069d4ffa49e2eb7dba. I will limit the review to the bounded five-file repair and will not use evidence from #825.

⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant