-
Notifications
You must be signed in to change notification settings - Fork 816
CMP-4438: Add manual rule kubevirt-restrict-vm-cluster-instance-preference-types (CIS OCP-Virt 1.13) #14938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
taimurhafeez
wants to merge
2
commits into
ComplianceAsCode:master
Choose a base branch
from
taimurhafeez:CMP-4438-Add-Manual-rule-restrict-create-modify-VM-cluster-instance-preference-types-(CIS-OCP-Virt-1.13)
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+35
−0
Open
CMP-4438: Add manual rule kubevirt-restrict-vm-cluster-instance-preference-types (CIS OCP-Virt 1.13) #14938
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
34 changes: 34 additions & 0 deletions
34
.../openshift-virtualization/kubevirt-restrict-vm-cluster-instance-preference-types/rule.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| documentation_complete: true | ||
|
|
||
| title: 'Restrict Create/Modify Virtual Machine Cluster Instance and Preference Types' | ||
|
|
||
| description: |- | ||
| Because the set of authorized subjects is specific to each environment, | ||
| this rule requires manual verification. Organizations can create a | ||
| CustomRule using CEL to automate this check by evaluating | ||
| ClusterRoleBindings and ClusterRoles for create and update access to | ||
| <tt>virtualmachineclusterinstancetypes</tt> and | ||
| <tt>virtualmachineclusterpreferences</tt> resources, verifying that | ||
| only approved subjects are bound to those permissions. | ||
|
|
||
| rationale: |- | ||
| Cluster instance types and preferences govern the default hardware | ||
| and configuration settings applied to new virtual machines. If | ||
| unauthorized subjects can create or modify these resources, they | ||
| can introduce overly permissive settings, disable security | ||
| controls, or allocate excessive resources across the cluster. | ||
| Restricting access ensures that only approved administrators | ||
| define the VM profiles available to tenants. | ||
|
|
||
| severity: medium | ||
|
|
||
| ocil_clause: 'unauthorized subjects can create or modify cluster instance or preference types' | ||
|
|
||
| ocil: |- | ||
| Run the following commands to check which subjects can create or | ||
| update cluster instance and preference types: | ||
| <pre>$ oc adm policy who-can create virtualmachineclusterinstancetypes</pre> | ||
| <pre>$ oc adm policy who-can update virtualmachineclusterinstancetypes</pre> | ||
| <pre>$ oc adm policy who-can create virtualmachineclusterpreferences</pre> | ||
| <pre>$ oc adm policy who-can update virtualmachineclusterpreferences</pre> | ||
| Verify that only authorized subjects are listed in the output. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.