CMP-4438: Add manual rule kubevirt-restrict-vm-cluster-instance-preference-types (CIS OCP-Virt 1.13) - #14938
Conversation
|
Hi @taimurhafeez. Thanks for your PR. I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
LGTM — the four who-can commands match the benchmark. One ask: rebase to drop the duplicated build-script/docs change once #14920 merges. |
rhmdnd
left a comment
There was a problem hiding this comment.
Overall questions about whether we want to add these manual rules in the first place, or be more intentional about suggesting custom rules instead?
rhmdnd
left a comment
There was a problem hiding this comment.
We're on the right track. Just need a rebase and an update to the description that points users to CustomRules as a way to automate this check.
…rence-types (CIS OCP-Virt 1.13)
explains manual status and points organizations to CustomRules for automation. Co-Authored-By: Claude Opus 4.6
bf04b21 to
637d00c
Compare
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Add a manual rule for CIS OCP-Virt control 1.13 "Restrict create/modify Virtual Machine Cluster Instance and Preference Types". The rule documents the audit procedure for checking who can create/update virtualmachineclusterinstancetypes and virtualmachineclusterpreferences, and is added to the cis-vm-extension CEL profile. Also relax build_cel_content.py to warn instead of error when a CEL profile references rules without CEL checks, allowing manual rules in CEL profiles. Update CEL documentation accordingly.
Co-Authored-By: Claude