Skip to content

CMP-4438: Add manual rule kubevirt-restrict-vm-cluster-instance-preference-types (CIS OCP-Virt 1.13) - #14938

Open
taimurhafeez wants to merge 2 commits into
ComplianceAsCode:masterfrom
taimurhafeez:CMP-4438-Add-Manual-rule-restrict-create-modify-VM-cluster-instance-preference-types-(CIS-OCP-Virt-1.13)
Open

CMP-4438: Add manual rule kubevirt-restrict-vm-cluster-instance-preference-types (CIS OCP-Virt 1.13)#14938
taimurhafeez wants to merge 2 commits into
ComplianceAsCode:masterfrom
taimurhafeez:CMP-4438-Add-Manual-rule-restrict-create-modify-VM-cluster-instance-preference-types-(CIS-OCP-Virt-1.13)

Conversation

@taimurhafeez

Copy link
Copy Markdown
Contributor

Add a manual rule for CIS OCP-Virt control 1.13 "Restrict create/modify Virtual Machine Cluster Instance and Preference Types". The rule documents the audit procedure for checking who can create/update virtualmachineclusterinstancetypes and virtualmachineclusterpreferences, and is added to the cis-vm-extension CEL profile. Also relax build_cel_content.py to warn instead of error when a CEL profile references rules without CEL checks, allowing manual rules in CEL profiles. Update CEL documentation accordingly.

Co-Authored-By: Claude

@openshift-ci openshift-ci Bot added the needs-ok-to-test Used by openshift-ci bot. label Jul 27, 2026
@openshift-ci

openshift-ci Bot commented Jul 27, 2026

Copy link
Copy Markdown

Hi @taimurhafeez. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jan-cerny jan-cerny added the OpenShift OpenShift product related. label Jul 28, 2026
@Vincent056

Copy link
Copy Markdown
Contributor

LGTM — the four who-can commands match the benchmark. One ask: rebase to drop the duplicated build-script/docs change once #14920 merges.

@rhmdnd rhmdnd left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall questions about whether we want to add these manual rules in the first place, or be more intentional about suggesting custom rules instead?

@openshift-ci openshift-ci Bot added the needs-rebase Used by openshift-ci bot. label Aug 5, 2026

@rhmdnd rhmdnd left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're on the right track. Just need a rebase and an update to the description that points users to CustomRules as a way to automate this check.

@rhmdnd rhmdnd added the CIS CIS Benchmark related. label Aug 5, 2026
explains manual status and points organizations to CustomRules for automation.

Co-Authored-By: Claude Opus 4.6
@taimurhafeez
taimurhafeez force-pushed the CMP-4438-Add-Manual-rule-restrict-create-modify-VM-cluster-instance-preference-types-(CIS-OCP-Virt-1.13) branch from bf04b21 to 637d00c Compare August 6, 2026 11:18
@openshift-ci openshift-ci Bot added needs-rebase Used by openshift-ci bot. and removed needs-rebase Used by openshift-ci bot. labels Aug 6, 2026
@openshift-ci

openshift-ci Bot commented Aug 7, 2026

Copy link
Copy Markdown

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CIS CIS Benchmark related. needs-ok-to-test Used by openshift-ci bot. needs-rebase Used by openshift-ci bot. OpenShift OpenShift product related.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants