Repository navigation
the product dashboard was still locked at 30d - #2885
Merged
Merged
Conversation
The hub got its timeframe control, the per-frontend dashboard did not, and that is the page the complaint was actually about: six cards all reading 30d with no way to ask what a frontend did yesterday. The harness has published 24h, 7d and 30d for revenue, volume, users and the period-over-period delta all along. Only the page was pinned. Two of the six cards do not simply follow the control, and say so rather than quietly reusing a 30d number under a "feed day" heading. Annualised scales the window's revenue to a year, so its multiplier moves with the window and the tip names it. Cohort share is defined as a share of the cohort's 24h notional; the harness publishes no 7d or 30d version and deriving one here would be inventing a number, so it stays 24h and the tip says why. The strip moves to its own client component because the dashboard is a server component. A stats object cached before byWindow existed falls back to the flat 30d fields rather than rendering a row of zeros for a cache cycle. Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picks #2884. The other half of the boss's "we need a way to iterate on the timeframe (right now it seems locked at 30D)" —
/hyperliquidgot its control in #2869, the per-frontend dashboard at/products/<slug>#hldid not, and that is the page with six cards all reading 30d.The harness has published 24h, 7d and 30d for revenue, volume, users and the delta all along. For fomo right now: $53,687 / $299,844 / $1,153,166 of revenue, and 2,995 / 8,874 / 24,682 users.
Two cards do not simply follow the control and say so, rather than reusing a 30d number under a "feed day" heading: Annualised scales the window's revenue to a year so its multiplier moves with it, and % cohort 24h vol stays 24h because the harness publishes no 7d or 30d cohort share and deriving one would be inventing it. The users card gains a tip for the multi-day windows, since those are a union of the daily sets and not a sum.
bun test src/,tsc --noEmit,eslint,pnpm buildclean.🤖 Generated with Claude Code