Repository navigation
version the snapshot keys, and stop the worker writing one by hand - #2887
Merged
Merged
Conversation
…2886) The reader serves an Upstash blob until it is ten minutes old, and a blob written under an older shape decodes with the new fields simply absent. When the product dashboard's timeframe control shipped, that bought six minutes where it rendered the 30d figures under all three labels. The fallback did its job and the page still showed one number three ways, which is a quieter wrong answer than an empty one. hl-hip3 already had the convention and the other two had not followed it. hl-frontends and hl-builder go to v2, so an old blob becomes unreachable rather than stale-but-readable. The per-builder key was also written by hand in two places in the reader and a third in the worker. A bump that missed the worker would have left the two writing and reading different keys, so the snapshot would simply never hit and every render would go to Prom. It is one exported helper now. Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picks #2886. Closes the gap #2885 exposed.
The Upstash reader serves a blob until it is ten minutes old, and one written under an older shape decodes with the new fields absent. The product dashboard's new timeframe control therefore spent six minutes rendering the 30d figures under all three labels — the fallback worked and the page still showed one number three ways.
hl-hip3already versioned its key;hl-frontendsandhl-builderhad not. Both go to v2 so an old blob is unreachable rather than stale-but-readable.The per-builder key was hand-written in three places, one of them in the worker. A bump that missed it would have had the two sides reading and writing different keys: the snapshot never hits, every render fans out ~13 Prom queries, and nothing looks broken. One exported helper now.
🤖 Generated with Claude Code