Skip to content

head_lag_pool_observed_total counts log events, not trades #2819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Flotapponnier wants to merge 1 commit into
base: main
Choose a base branch
from
Open

head_lag_pool_observed_total counts log events, not trades #2819

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion harnesses/aggregator-head-lag/cmd/script/metrics.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,15 @@ func init() {
headLagPoolSeen = prometheus.NewCounterVec(
prometheus.CounterOpts{
Name: "head_lag_pool_observed_total",
Help: "Trades observed by the bench pool subscription, per chain.",
// Log EVENTS, not trades, and the difference is a factor of
// several on EVM: eth_subscribe on a pool address delivers every
// event it emits (Swap, Mint, Burn, Collect), so one swap can
// arrive as several. Measured on the BNB pool: 49,672 events an
// hour against roughly 18,380 swaps. Solana logsSubscribe is per
// transaction, so there the two coincide. Use it to tell a live
// subscription from a dead one, never as a trade count.
Help: "Log events delivered by the bench pool subscription, per chain. " +
"Several per swap on EVM chains; one per transaction on Solana.",
},
[]string{"chain"},
)
Expand Down
Loading