Repository navigation
head_lag_pool_observed_total counts log events, not trades - #2819
Open
Flotapponnier wants to merge 1 commit into
Open
Flotapponnier wants to merge 1 commit into
Flotapponnier wants to merge 1 commit into
Conversation
I wrote the Help as "Trades observed by the bench pool subscription" in #2811 and then read the counter back as a trade rate while checking the new alert rules. On EVM it is neither. eth_subscribe on a pool address delivers every event the pool emits (Swap, Mint, Burn, Collect), so one swap can arrive as several. Measured on the BNB pool: 49,672 events an hour against roughly 18,380 swaps, a factor of 2.7. Solana logsSubscribe is per transaction, so there the two coincide, which is why the mislabel survived: every number I had checked it against was Solana. Help string only, no behaviour change. The counter is still exactly right for what the race filter uses it for, which is telling a live pool subscription from a dead one, and for the two alert rules added today that test it against zero. It is wrong only as a trade count, which is how I was about to read it. Rides the next harness deploy; not worth one of its own. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wrote the Help as "Trades observed by the bench pool subscription" in #2811, then read the counter back as a trade rate while sanity-checking today's new alert rules. On EVM it is neither.
eth_subscribeon a pool address delivers every event the pool emits (Swap, Mint, Burn, Collect), so one swap can arrive as several. Measured on the BNB pool: 49,672 events/h against roughly 18,380 swaps, a factor of 2.7. SolanalogsSubscribeis per transaction, so there the two coincide — which is why the mislabel survived, since every number I had checked it against was Solana.Help string only, no behaviour change. The counter is still exactly right for what it is used for: telling a live pool subscription from a dead one in
race.go, and the two alert rules added today that test it against zero. It is wrong only as a trade count, which is how I was about to read it.Rides the next harness deploy; not worth one of its own.
🤖 Generated with Claude Code