Skip to content

Forward datastores.mount() kwargs in non-persistent path to restore MSI/IMDS auth parity #47283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Forward datastores.mount() kwargs in non-persistent path to restore MSI/IMDS auth parity #47283

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9c208e3
Initial plan
Copilot Jun 2, 2026
ea4d4a4
Forward mount kwargs to datastore fuse subprocess
Copilot Jun 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion sdk/ml/azure-ai-ml/azure/ai/ml/operations/_datastore_operations.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,5 +325,10 @@ def mount(
time.sleep(5)
else:
rslex_fuse_subprocess_wrapper.start_fuse_mount_subprocess(
uri, mount_point, read_only, debug, credential=self._operation._config.credential
uri,
mount_point,
read_only,
debug,
credential=self._operation._config.credential,
**kwargs,
)
8 changes: 8 additions & 0 deletions sdk/ml/azure-ai-ml/tests/datastore/unittests/test_datastore_operations.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,9 +114,17 @@ def test_mount_non_persistent(
path="azureml://datastores/random_name",
mount_point="/tmp/mount/random-local-path-for-datastore/",
persistent=False,
client_id="test-client-id",
identity_endpoint_type="Imds",
)
mock_build_uri.assert_called_once()
mock_start_subprocess.assert_called_once()
assert (
mock_start_subprocess.call_args.kwargs["credential"]
== mock_datastore_operation._operation._config.credential
)
assert mock_start_subprocess.call_args.kwargs["client_id"] == "test-client-id"
assert mock_start_subprocess.call_args.kwargs["identity_endpoint_type"] == "Imds"

def test_get_default(self, mock_from_rest, mock_datastore_operation: DatastoreOperations):
mock_datastore_operation.get_default()
Expand Down
Loading