Skip to content

Forward datastores.mount() kwargs in non-persistent path to restore MSI/IMDS auth parity#47283

Draft
Copilot wants to merge 2 commits into
mainfrom
copilot/fix-mlclient-datastores-mount
Draft

Forward datastores.mount() kwargs in non-persistent path to restore MSI/IMDS auth parity#47283
Copilot wants to merge 2 commits into
mainfrom
copilot/fix-mlclient-datastores-mount

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Jun 2, 2026

MLClient.datastores.mount() accepted **kwargs but dropped them in the non-persistent mount path, preventing IMDS MSI parameters (for example client_id, identity_endpoint_type) from reaching dataprep/rslex. On non-AML-compute VMs this caused auth fallback to interactive/device-code flows and mount failure.

  • What changed

    • In DatastoreOperations.mount(...), updated the non-persistent branch to forward **kwargs into:
      • rslex_fuse_subprocess_wrapper.start_fuse_mount_subprocess(...)
    • This preserves caller-supplied auth parameters for fuse mount subprocess startup.
  • Unit test updates

    • Extended datastore non-persistent mount unit coverage to pass:
      • client_id="test-client-id"
      • identity_endpoint_type="Imds"
    • Added assertions verifying these kwargs are forwarded to start_fuse_mount_subprocess (alongside existing credential forwarding).
rslex_fuse_subprocess_wrapper.start_fuse_mount_subprocess(
    uri,
    mount_point,
    read_only,
    debug,
    credential=self._operation._config.credential,
    **kwargs,
)

Co-authored-by: mohammadsheraj <221899694+mohammadsheraj@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix MLClient.datastores.mount() for MSI on non-AML-compute VMs Forward datastores.mount() kwargs in non-persistent path to restore MSI/IMDS auth parity Jun 2, 2026
Copilot AI requested a review from mohammadsheraj June 2, 2026 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Regression: MLClient.datastores.mount() fails with MSI on non-AML-compute VMs (worked in SDK v1)

2 participants