Move function family out-of-line into MLIRGenFunctions.cpp (§1)#223
Merged
Conversation
…c 1) 23 function-machinery methods (parameters, prototype, name resolution, return-type/captured-vars discovery, FunctionDeclaration, generator, function-like declaration incl. dynamic import, entry/exit, captured params, params/bindings, captures, both mlirGenFunctionBody overloads, resolve/create capture, resolveFunctionWithCapture, registerFunctionOp) move from MLIRGenImpl.h into a new MLIRGenFunctions.cpp TU; header keeps declarations (defaults preserved on declarations, stripped from definitions). 1408 lines out of the header (17624 -> 16219). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
§1 TU split, next slice — same pattern as #217–#222.
23 function-machinery methods move from
MLIRGenImpl.hinto a newMLIRGenFunctions.cppTU:mlirGenParameters,getNameOfFunction,mlirGenFunctionPrototype,discoverFunctionReturnTypeAndCapturedVars,mlirGen(FunctionDeclaration),mlirGenFunctionGenerator,registerFunctionOp,mlirGenFunctionLikeDeclaration(+DynamicImport), entry/exit, captured-param handling, params/bindings, captures, bothmlirGenFunctionBodyoverloads,mlirGenResolveCapturedVars/mlirGenCreateCapture, andresolveFunctionWithCapture.Remaining §1 families: classes, then the tail utilities.
Test plan
🤖 Generated with Claude Code