Move class family out-of-line into MLIRGenClasses.cpp (§1)#224
Merged
Conversation
37 class-machinery methods (class info/type/storage, static fields, members, heritage clauses incl. implements, data/static field members, accessors, constructors incl. defaults, class-new, size/type-descriptor /bitmap statics, instanceOf, interface vtables, virtual table definition, index/method/static-block members, generic class registration, global ctor, constructor statements) move from MLIRGenImpl.h into a new MLIRGenClasses.cpp TU; the header keeps declarations. mlirGenClassType<T> template stays inline. 2008 lines out of the header (16219 -> 14212). Extractor fix: method-close detection now tolerates trailing whitespace after the closing brace - the root cause of the two mis-extractions in the previous slice. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
§1 TU split — the last big family, same pattern as #217–#223.
37 class-machinery methods move from
MLIRGenImpl.hinto a newMLIRGenClasses.cppTU: class info/type/storage generation, static fields, member processing, heritage clauses (incl. implements), data/static field members and accessors, constructors (incl. default and static-default), class-new,.size/type-descriptor/type-bitmap statics,instanceOf, interface vtables (mlirGenCreateInterfaceVTableForClass, per-interface definitions), the virtual-table definition, index/method/static-block members, generic-class registration,createGlobalConstructor, andgenerateConstructorStatements. ThemlirGenClassType<T>template stays inline in the header.}line while several bodies end with trailing whitespace after the brace. The close/open matchers are now whitespace-tolerant; this was also the root cause of the two mis-extractions fixed manually in Move function family out-of-line into MLIRGenFunctions.cpp (§1) #223.Remaining §1: the tail utilities (exports, namespace helpers, lookup accessors) — one final slice.
Test plan
🤖 Generated with Claude Code