Skip to content

feat(mobile): add Expo React Native app#49

Open
gac0812 wants to merge 3 commits into
1024XEngineer:mainfrom
gac0812:feat/mobile-app-upstream
Open

feat(mobile): add Expo React Native app#49
gac0812 wants to merge 3 commits into
1024XEngineer:mainfrom
gac0812:feat/mobile-app-upstream

Conversation

@gac0812

@gac0812 gac0812 commented Jul 16, 2026

Copy link
Copy Markdown

Summary

  • add the Timeflow Expo React Native application under frontend/
  • add the initial screen and design constants
  • configure TypeScript, ESLint, and Prettier

Validation

  • npm run check
  • npx expo config --type public

@fennoai fennoai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Found two actionable issues; details are inline.

Validation: npm run check, npx expo config --type public, Expo Doctor, and an Android export passed. The web export reproduced the dependency failure noted inline.

View job run

Comment thread frontend/package.json Outdated
"start": "expo start",
"android": "expo start --android",
"ios": "expo start --ios",
"web": "expo start --web",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

High: The advertised web command is unusable from a clean checkout. npx expo export --platform web exits because react-dom@19.2.3 and react-native-web@^0.21.2 are not installed. Since web is exposed here and configured in app.json, add the Expo-compatible web dependencies (including lockfile changes), or remove web support.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in gac0812@be65e6c. Timeflow currently targets Android, so I removed the advertised Web script, Expo Web configuration, and Web-only favicon instead of adding unused dependencies. Verified npm run check, Expo public config (iOS/Android only), and an Android export.

Comment thread frontend/LICENSE Outdated
@@ -0,0 +1,21 @@
The MIT License (MIT)

Copyright (c) 2015-present 650 Industries, Inc. (aka Expo)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Medium: This folder-level license attributes the newly added Timeflow frontend to 650 Industries. The notice appears copied from Expo and would misleadingly apply to the app code under frontend/. Replace it with the project's intended copyright/license, or remove it if licensing is handled at the repository level.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in gac0812@34bc621. Removed the copied Expo/650 Industries folder-level license so it no longer misattributes the Timeflow application. A project-wide license can be added at the repository root once the maintainers choose one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant