feat(tooling): add quality check workflow#50
Conversation
| 一键全量检查: | ||
|
|
||
| ```bash | ||
| bash scripts/check-all.sh # 前后端全部 |
There was a problem hiding this comment.
High: The documented scripts/check-all.sh entry point does not exist in this PR, main, or either declared dependency PR (#48/#49). After the documented merge order, every command in this block still fails with No such file or directory; add the script (and make it executable) or document the actual backend/frontend commands instead.
There was a problem hiding this comment.
Fixed in gac0812@6a4b8c4. Added executable scripts/check-all.sh with all, backend, and frontend targets plus invalid-target validation. Verified bash -n scripts/check-all.sh and the complete quality-check run.
| ## Git hooks(提交/推送拦截) | ||
|
|
||
| hooks 不预置在仓库中。git 仓库就绪后,在 Cursor 里对 AI 说「启用 git hooks」,AI 会按 | ||
| `.cursor/skills/timeflow-git-hooks/SKILL.md` 中的模板把三个 hook 写入 `.git/hooks/` 并验证: |
There was a problem hiding this comment.
High: This hook setup depends on .cursor/skills/timeflow-git-hooks/SKILL.md, but that file is absent from this PR and dependency PRs #48/#49; the development-standards skill referenced on line 33 is absent as well. Consequently the promised Cursor workflow cannot install or validate any hooks. Include the skill definitions in the merge set or remove these instructions.
There was a problem hiding this comment.
Fixed in gac0812@6a4b8c4. Added the always-applied Cursor rule and both referenced skill definitions to this PR, including the hook installation and validation templates.
| hooks 不预置在仓库中。git 仓库就绪后,在 Cursor 里对 AI 说「启用 git hooks」,AI 会按 | ||
| `.cursor/skills/timeflow-git-hooks/SKILL.md` 中的模板把三个 hook 写入 `.git/hooks/` 并验证: | ||
|
|
||
| - `pre-commit`:按改动范围跑对应端检查,不过不让提交 |
There was a problem hiding this comment.
Medium: 不过不让提交 says the pre-commit hook runs checks but does not allow commits at all, which contradicts the intended conditional gate. If the hook blocks only failing checks, this should say 不通过不让提交 (or otherwise describe the real condition).
There was a problem hiding this comment.
Fixed in gac0812@6a4b8c4. The README now states that pre-commit runs checks for the affected area and blocks the commit only when those checks fail.
Summary
Dependencies
Issue
Fixes #51
This documentation and tooling should merge after the backend and mobile application changes are available.