Add flexible deserialization for datetime fill values #3031
+72
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs release notes
github-actions
bot
removed
the
needs release notes
d-v-b
reviewed
May 2, 2025
| pass | ||
| elif dtype.kind in "M": |
There was a problem hiding this comment.
Suggested change
| elif dtype.kind in "M": | |
| elif dtype.kind in ("M", "m"): |
handle timedelta64 as well
moradology
force-pushed
the
fix/v2-NaT-fill_value
branch
from
a49aac9 to
a2edd4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a backwards incompatibility issue created in recent standardization of the fill_value serialization/deserialization work. It does so by adopting a flexible decoding approach that takes either the minimum signed 64bit value or else 'NaT' as meaning
Not a Timewhile sticking to writing fill values as 'NaT'.Fixes #3028
TODO:
docs/user-guide/*.rstchanges/