-
-
Notifications
You must be signed in to change notification settings - Fork 328
Implement Store.move #3021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
brokkoli71
wants to merge
14
commits into
zarr-developers:main
Choose a base branch
from
scalableminds:store-move
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Implement Store.move #3021
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
841df35
move for LocalStore
brokkoli71 e6d7c8d
Merge branch 'main' into store-move
brokkoli71 0ae0fda
move for ZipStore
brokkoli71 92eec5f
remove redundant check
brokkoli71 2cd1482
open and close zipstore
brokkoli71 12ab2fd
fix zipstore.move
brokkoli71 4f4a15a
Merge branch 'main' into store-move
brokkoli71 1fe39bb
fix localstore.move for ndim>1
brokkoli71 95fc4b6
Merge remote-tracking branch 'origin/store-move' into store-move
brokkoli71 25d1c9d
format
brokkoli71 2788467
remove abstract Store .move
brokkoli71 6f07fe1
document changes
brokkoli71 cd55178
Merge branch 'main' into store-move
brokkoli71 ee30274
Merge branch 'main' into store-move
brokkoli71 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Implemented ``move`` for ``LocalStore`` and ``ZipStore``. This allows users to move the store to a different root path. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not use
shutil.move
to move the entire folder?If implementing this ourselves, the newly created folders might need to copy the permissions and settings of the source folders. And, we could put the move operations on a thread pool.