fix: wrap the fsspec fs in an AsyncWrapper also if it is called with asynchronouos=False #2993
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a zarr is open from an fsspec URL, like
simplecache::https://some.url.org
it failed because the underlying fsspec filesystem (simplecache) is anAsyncFileSystem
but it is not instantiated withasynchronouos=True
. This led to errors.This PR wraps the
fs
in anAsyncFileSystemWrapper
to ensure that it is asynchronouos.TODO:
[ ] Add unit tests and/or doctests in docstrings[ ] Add docstrings and API docs for any new/modified user-facing classes and functions[ ] New/modified features documented indocs/user-guide/*.rst
changes/