Skip to content

fix: wrap the fsspec fs in an AsyncWrapper also if it is called with asynchronouos=False #2993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nils3er
Copy link

@nils3er nils3er commented Apr 17, 2025

If a zarr is open from an fsspec URL, like simplecache::https://some.url.org it failed because the underlying fsspec filesystem (simplecache) is an AsyncFileSystem but it is not instantiated with asynchronouos=True. This led to errors.

This PR wraps the fs in an AsyncFileSystemWrapper to ensure that it is asynchronouos.

TODO:

  • [ ] Add unit tests and/or doctests in docstrings
  • [ ] Add docstrings and API docs for any new/modified user-facing classes and functions
  • [ ] New/modified features documented in docs/user-guide/*.rst
  • Changes documented as a new file in changes/
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@github-actions github-actions bot added the needs release notes Automatically applied to PRs which haven't added release notes label Apr 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs release notes Automatically applied to PRs which haven't added release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant