Dont depend on hal #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
usbalbin
commented
Apr 24, 2025
usbalbin
commented
Apr 26, 2025
| @@ -26,6 +22,7 @@ cortex-m = { version = "0.7.7", features = ["critical-section-single-core"] } | |||
| defmt-rtt = "0.4.0" | |||
| cortex-m-rt = "0.7.2" | |||
| panic-probe = { version = "0.3.0", features = ["print-defmt"] } | |||
| stm32g4xx-hal = { git = "https://github.com/usbalbin/stm32g4xx-hal", branch = "hrtim", features = ["defmt", "hrtim"] } | |||
There was a problem hiding this comment.
@burrbull As far as I know we can not have optional dev dependendecies and thus need to select one hal to use for the examples. Would it then be better to let the examples live in the corresponding hals? See stm32-rs/stm32g4xx-hal#192
|
it should not be hard to rebase. So I'm fine. |
usbalbin
added a commit
that referenced
this pull request
May 2, 2025
* Dont depend on hal * Remove connect pins * Move out device specific things to hals * update pac * Update CI * fixes * Fix errors for f334 and h7 * Update examples * clippy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid depending on hals. Most of the removed code will have to be moved out to the corresponding hals.
See stm32-rs/stm32g4xx-hal#192 for corresponding hal changes