Skip to content

Add back the CloudWatch log group source and enhanced the log filtration using FilterLogEvents API #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 20, 2025

Conversation

ParthaI
Copy link
Contributor

@ParthaI ParthaI commented May 5, 2025

Example query results

Results
Add example SQL query results here (please include the input queries as well)

@ParthaI ParthaI requested a review from cbruno10 May 5, 2025 10:26
@ParthaI ParthaI self-assigned this May 5, 2025
@ParthaI ParthaI requested a review from Copilot May 5, 2025 10:26
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reinstates support for a CloudWatch log group source across multiple AWS log tables, adding both implementation and documentation.

  • Added CloudWatch log group source support to WAF traffic and CloudTrail log tables.
  • Implemented CloudWatch log group source configuration, state management, and client interactions.
  • Updated documentation examples and registered the source in the AWS plugin.

Reviewed Changes

Copilot reviewed 10 out of 11 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
tables/waf_traffic_log/waf_traffic_log_table.go Added CloudWatch source import and metadata entry for WAF logs.
tables/cloudtrail_log/cloudtrail_log_table.go Added CloudWatch source import and metadata entry for CloudTrail logs.
sources/cloudwatch_log_group/cloudwatch_log_group_source_config.go Introduced CloudWatch log group source configuration.
sources/cloudwatch_log_group/cloudwatch_log_group_source.go Implements the CloudWatch log group source functionality.
sources/cloudwatch_log_group/cloudwatch_log_group_collection_state.go Implements collection state tracking for CloudWatch events.
docs/tables/aws_waf_traffic_log/index.md Added documentation examples for CloudWatch log groups in WAF logs.
docs/tables/aws_cloudtrail_log/index.md Added documentation examples for CloudWatch log groups in CloudTrail logs.
docs/sources/aws_cloudwatch_log_group.md New documentation page for the CloudWatch log group source.
aws/plugin.go Registered the CloudWatch log group row source in the plugin.
Files not reviewed (1)
  • go.mod: Language not supported

@ParthaI ParthaI changed the title Add back the CloudWatch log group source Add back the CloudWatch log group source and enhanced the log filtration using FilterLogEvents API May 5, 2025
@ParthaI ParthaI requested a review from Copilot May 12, 2025 07:01
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reintroduces and enhances the CloudWatch log group source while updating both WAF and CloudTrail log tables to support the new source. Key changes include:

  • Adding CloudWatch log group source metadata in WAF and CloudTrail tables.
  • Implementing the CloudWatch log group source and its collection state with incremental log processing.
  • Updating documentation and dependency management (go.mod) to support the new source.

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tables/waf_traffic_log/waf_traffic_log_table.go Added CloudWatch log group source metadata for WAF logs.
tables/cloudtrail_log/cloudtrail_log_table.go Added CloudWatch log group source metadata for CloudTrail logs.
sources/cloudwatch_log_group/cloudwatch_log_group_source_config.go Validates configuration for CloudWatch log group source.
sources/cloudwatch_log_group/cloudwatch_log_group_source.go Implements log collection and filtering logic for CloudWatch log groups.
sources/cloudwatch_log_group/cloudwatch_log_group_collection_state.go Implements collection state logic for CloudWatch log groups.
go.mod Added dependency on AWS CloudWatch Logs SDK.
docs/* Updated documentation with examples for the new CloudWatch log group source.
aws/plugin.go Registers the new CloudWatch log group source.

ParthaI and others added 2 commits May 12, 2025 14:19
@ParthaI ParthaI requested a review from graza-io May 16, 2025 10:44
@graza-io graza-io merged commit 888070a into main May 20, 2025
1 check passed
@graza-io graza-io deleted the enhance-cw-source branch May 20, 2025 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants