feat: Enable touch-based panning and pinch-to-zoom in SchematicViewer on mobile devices #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
I tired it in mobile, can't zoom in!! |
|
Make sure to actually test in a mobile before requesting reviews |
|
@imrishabh18 OK !! |
|
@imrishabh18 Ready for review !! |
mohan-bee
changed the title
mohan-bee
changed the title
Anshgrover23
suggested changes
May 3, 2025
There was a problem hiding this comment.
@mohan-bee try in your android/IOS device not in browser android view and attached good video reference.
|
@Anshgrover23 Here is the tested mobile version! Record_2025-05-03-11-34-31.mp4 |
Anshgrover23
approved these changes
May 3, 2025
|
@imrishabh18 afaik he just needs to update use mouse matrix transform, the diff for this looks a bit wack to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #87
/claim #87
Screen.Recording.2025-05-02.at.10.54.28.PM.mov