-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Add twitterX, Gitlab, Instagram, Reddit and Bugtracker social links #646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add twitterX, Gitlab, Instagram, Reddit and Bugtracker social links #646
Conversation
…cellent hover-color suggestion from Cursor editor
…on from from the css
This reverts commit 948004f.
* refactor-social-icons: Remove unused prefix param from PageSocial and don't interpolate Mastodon link title
@onnimonni is attempting to deploy a commit to the Saasify Team on Vercel. A member of the Team first needs to authorize it. |
Removed dependencies detected. Learn more about Socket for GitHub ↗︎ 🚮 Removed packages: npm/@react-icons/all-files@4.1.0 |
… gradient background
Pull Request Review: Add twitterX, Gitlab, Instagram, Reddit and Bugtracker social linksThank you for this pull request! I've reviewed the changes to add additional social media links to the project. Overall ImpressionThis PR adds several new social media link options including TwitterX, GitLab, Instagram, Reddit, and Bugtracker. The implementation looks well thought out and appears to build on previous refactoring work that improved the social icons system. Positive Aspects
Things to Consider
Code Questions
ConclusionThis looks like a valuable addition to the project that will give users more flexibility in configuring their social links. The code changes appear well-structured, but please consider addressing the questions and considerations above. I'd recommend merging this after ensuring the documentation is updated and any necessary testing is completed. |
This is part of chain of PRs which I would like to merge as small changes so that they are easier to review.
Please start from #642 and then proceed to #644.
After that we should be ready to merge these new social icons.
This replaces #591.
Demo video
Screen.Recording.2024-01-29.at.18.16.57.mov