Skip to content

Add twitterX, Gitlab, Instagram, Reddit and Bugtracker social links #646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

onnimonni
Copy link
Contributor

@onnimonni onnimonni commented Nov 1, 2024

This is part of chain of PRs which I would like to merge as small changes so that they are easier to review.
Please start from #642 and then proceed to #644.

After that we should be ready to merge these new social icons.

This replaces #591.

Demo video

Screen.Recording.2024-01-29.at.18.16.57.mov

Copy link

vercel bot commented Nov 1, 2024

@onnimonni is attempting to deploy a commit to the Saasify Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

socket-security bot commented Nov 1, 2024

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: npm/@react-icons/all-files@4.1.0

View full report↗︎

@onnimonni onnimonni changed the title Add Gitlab, Instagram, Reddit and Bugtracker social links Add twitterX, Gitlab, Instagram, Reddit and Bugtracker social links Nov 1, 2024
Copy link

charliechecks bot commented Mar 18, 2025

Pull Request Review: Add twitterX, Gitlab, Instagram, Reddit and Bugtracker social links

Thank you for this pull request! I've reviewed the changes to add additional social media links to the project.

Overall Impression

This PR adds several new social media link options including TwitterX, GitLab, Instagram, Reddit, and Bugtracker. The implementation looks well thought out and appears to build on previous refactoring work that improved the social icons system.

Positive Aspects

  • Good refactoring approach by consolidating social icon definitions and colors in one place
  • Elimination of dangerouslySetInnerHTML in favor of safer CSS approaches
  • Nice implementation of Instagram's gradient background using a custom background setting
  • Well-organized commits with descriptive messages
  • Includes a demo video, which is helpful for visual confirmation

Things to Consider

  1. Package Management: Replacing @react-icons/all-files with react-icons seems like a good move for more up-to-date icons, but did you check for any bundle size implications?

  2. Backward Compatibility: Are there any breaking changes for users who might have configured the previous social links? It's worth documenting any migration steps if needed.

  3. Documentation: Consider updating the documentation to reflect the new social media options and how to configure them.

  4. Testing: Have all the new social links been tested across different browsers and screen sizes?

  5. Internationalization: Are there any text elements in these new social icons that might need translation?

Code Questions

  • For the Instagram gradient background, have you tested how it renders on different display types (e.g., dark mode)?
  • Is there a reason for the specific ordering of the social icons? Consider if there should be a way for users to customize the order.

Conclusion

This looks like a valuable addition to the project that will give users more flexibility in configuring their social links. The code changes appear well-structured, but please consider addressing the questions and considerations above.

I'd recommend merging this after ensuring the documentation is updated and any necessary testing is completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant